[dpdk-dev] [PATCH] net/sfc: do not use RSS context if it is not required

[dpdk-dev] [PATCH] net/sfc: do not use RSS context if it is not required

[Andrew Rybchenko]

RSS action with only one destination queue and no specific settings
for hash types and key does not require dedicated RSS context and
may be simplified to QUEUE action.

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Roman Zhukov <roman.zhukov@oktetlabs.ru>
---
 drivers/net/sfc/sfc_flow.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index 41b5987b2..b7e54d77f 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -1295,6 +1295,17 @@ sfc_flow_parse_rss(struct sfc_adapter *sa,
 	if (action_rss->level)
 		return -EINVAL;
 
+	/*
+	 * Dummy RSS action with only one queue and no specific settings
+	 * for hash types and key does not require dedicated RSS context
+	 * and may be simplified to single queue action.
+	 */
+	if (action_rss->queue_num == 1 && action_rss->types == 0 &&
+	    action_rss->key_len == 0) {
+		flow->spec.template.efs_dmaq_id = rxq_hw_index_min;
+		return 0;
+	}
+
 	if (action_rss->types) {
 		int rc;
 
-- 
2.14.1

Re: [dpdk-dev] [PATCH] net/sfc: do not use RSS context if it is not required

[Ferruh Yigit]

On 4/26/2018 5:48 PM, Andrew Rybchenko wrote:
> RSS action with only one destination queue and no specific settings
> for hash types and key does not require dedicated RSS context and
> may be simplified to QUEUE action.
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Roman Zhukov <roman.zhukov@oktetlabs.ru>

Applied to dpdk-next-net/master, thanks.