* [dpdk-dev] [PATCH] net/axgbe: fix coverity issue 277239
@ 2018-05-02 8:47 Ravi Kumar
2018-05-02 11:01 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Ravi Kumar @ 2018-05-02 8:47 UTC (permalink / raw)
To: dev; +Cc: john.mcnamara
Stored register value to enable jumbo frame was always
overwritten. Assigning value based on rx_buf_size.
Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
---
drivers/net/axgbe/axgbe_dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c
index d05f9c8..707f1ee 100644
--- a/drivers/net/axgbe/axgbe_dev.c
+++ b/drivers/net/axgbe/axgbe_dev.c
@@ -1019,7 +1019,6 @@ static void axgbe_config_jumbo_enable(struct axgbe_port *pdata)
unsigned int val;
val = (pdata->rx_buf_size > AXGMAC_STD_PACKET_MTU) ? 1 : 0;
- val = 1;
AXGMAC_IOWRITE_BITS(pdata, MAC_RCR, JE, val);
}
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/axgbe: fix coverity issue 277239
2018-05-02 8:47 [dpdk-dev] [PATCH] net/axgbe: fix coverity issue 277239 Ravi Kumar
@ 2018-05-02 11:01 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-05-02 11:01 UTC (permalink / raw)
To: Ravi Kumar, dev; +Cc: john.mcnamara
On 5/2/2018 9:47 AM, Ravi Kumar wrote:
> Stored register value to enable jumbo frame was always
> overwritten. Assigning value based on rx_buf_size.
>
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
Updated as:
net/axgbe: fix value always overwritten
Stored register value to enable jumbo frame was always
overwritten. Assigning value based on rx_buf_size.
Coverity issue: 277239
Fixes: 7c4158a5b592 ("net/axgbe: add DMA programming and start/stop")
Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-02 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 8:47 [dpdk-dev] [PATCH] net/axgbe: fix coverity issue 277239 Ravi Kumar
2018-05-02 11:01 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).