From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2B6AD37A2 for ; Thu, 3 May 2018 10:58:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2018 01:58:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,357,1520924400"; d="scan'208";a="47960899" Received: from jeffguo-z170x-ud5.sh.intel.com (HELO localhost.localdomain) ([10.67.104.10]) by orsmga003.jf.intel.com with ESMTP; 03 May 2018 01:58:44 -0700 From: Jeff Guo To: stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, jianfeng.tan@intel.com Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, jia.guo@intel.com, helin.zhang@intel.com Date: Thu, 3 May 2018 16:57:09 +0800 Message-Id: <1525337829-3893-5-git-send-email-jia.guo@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525337829-3893-1-git-send-email-jia.guo@intel.com> References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1525337829-3893-1-git-send-email-jia.guo@intel.com> Subject: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle hot unplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 08:58:48 -0000 Use testpmd for example, to show how an application smoothly handle failure when device being hot unplug. Once app detect the removal event, the callback would be called, it first stop the packet forwarding, then stop the port, close the port and finally detach the port. Signed-off-by: Jeff Guo --- v21->v20: fix attach port issue, let it work for multiple device case. --- app/test-pmd/testpmd.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index db23f23..81f41e3 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1908,9 +1908,10 @@ eth_dev_event_callback_unregister(void) void attach_port(char *identifier) { - portid_t pi = 0; unsigned int socket_id; + portid_t pi = rte_eth_dev_count_avail(); + printf("Attaching a new port...\n"); if (identifier == NULL) { @@ -2079,6 +2080,26 @@ rmv_event_callback(void *arg) dev->device->name); } +static void +rmv_dev_event_callback(char *dev_name) +{ + uint16_t port_id; + int ret; + + ret = rte_eth_dev_get_port_by_name(dev_name, &port_id); + if (ret) { + printf("can not get port by device %s!\n", dev_name); + return; + } + + RTE_ETH_VALID_PORTID_OR_RET(port_id); + printf("removing port id:%u\n", port_id); + stop_packet_forwarding(); + stop_port(port_id); + close_port(port_id); + detach_port(port_id); +} + /* This function is used by the interrupt thread */ static int eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param, @@ -2141,9 +2162,7 @@ eth_dev_event_callback(char *device_name, enum rte_dev_event_type type, case RTE_DEV_EVENT_REMOVE: RTE_LOG(ERR, EAL, "The device: %s has been removed!\n", device_name); - /* TODO: After finish failure handle, begin to stop - * packet forward, stop port, close port, detach port. - */ + rmv_dev_event_callback(device_name); break; case RTE_DEV_EVENT_ADD: RTE_LOG(ERR, EAL, "The device: %s has been added!\n", @@ -2666,7 +2685,6 @@ main(int argc, char** argv) return -1; } eth_dev_event_callback_register(); - } if (start_port(RTE_PORT_ALL) != 0) -- 2.7.4