From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 00/18] Fix build on gcc8 and various bugs
Date: Tue, 08 May 2018 12:29:28 +0800 [thread overview]
Message-ID: <152575364588.56689.3300796065057551728.stgit@localhost.localdomain> (raw)
The following series gets current master able to build
on Fedora 28 + x86_64 using gcc 8.0.1. There were a
number of build-breaking problems, mostly around correct
string processing but all of them reflecting some issue
in the code.
Of the two major issues, one around struct alignment in
dpaa I think is properly fixed by the patch 3/18 here,
but for the apparently broken hash function cast in 1/18
I just stopped it breaking the build; unless I miss the
trick it seems it needs fixing properly after some
further discussion.
Because of the kind of widespread string processing /
off-by-one / buffer overflow issue fixed here, I think it'd
be a really good idea to run this stuff through Coverity.
They will give you a free account for OSS projects here
https://scan.coverity.com/
---
Andy Green (18):
lib: ret_table: workaround hash function cast error
drivers: bus: pci: fix strncpy dangerous code
drivers: bus: dpaa: fix inconsistent struct alignment
drivers: net: axgbe: fix broken eeprom string comp
drivers: net: nfp: nfpcore: fix strncpy misuse
drivers: net: nfp: nfpcore fix off-by-one and no NUL on strncpy use
drivers: net: nfp: don't memcpy out of source range
drivers: net: nfp: fix buffer overflow in fw_name
drivers: net: qede: fix strncpy constant and NUL
drivers: net: qede: fix broken strncpy
drivers:net:sfc: fix strncpy length
drivers: net: sfc: fix another strncpy size and NUL
drivers: net: vdev: readlink inputs cannot be aliased
drivers: net: vdev: fix 3 x strncpy misuse
test-pmd: can't find include
app: fix sprintf overrun bug
app: test-bbdev: strcpy ok for allocated string
app: test-bbdev: strcpy ok for allocated string 2
app/proc-info/main.c | 9 +++++++--
app/test-bbdev/test_bbdev_vector.c | 5 +++--
app/test-pmd/Makefile | 1 +
drivers/bus/dpaa/base/qbman/qman.c | 14 +++++++-------
drivers/bus/dpaa/include/fsl_qman.h | 24 +++++++++++++-----------
drivers/bus/pci/linux/pci.c | 3 ++-
drivers/net/axgbe/axgbe_phy_impl.c | 4 ++--
drivers/net/nfp/nfp_net.c | 4 ++--
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ++-
drivers/net/nfp/nfpcore/nfp_resource.c | 6 +++---
drivers/net/qede/base/ecore_int.c | 10 ++++++----
drivers/net/qede/qede_main.c | 3 ++-
drivers/net/sfc/sfc_ethdev.c | 9 ++++++---
drivers/net/vdev_netvsc/vdev_netvsc.c | 16 ++++++++++------
lib/librte_table/rte_table_hash_cuckoo.c | 2 +-
15 files changed, 67 insertions(+), 46 deletions(-)
--
next reply other threads:[~2018-05-08 4:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 4:29 Andy Green [this message]
2018-05-08 4:29 ` [dpdk-dev] [PATCH 01/18] lib: ret_table: workaround hash function cast error Andy Green
2018-05-08 4:29 ` [dpdk-dev] [PATCH 02/18] drivers: bus: pci: fix strncpy dangerous code Andy Green
2018-05-08 8:57 ` Bruce Richardson
2018-05-08 4:29 ` [dpdk-dev] [PATCH 03/18] drivers: bus: dpaa: fix inconsistent struct alignment Andy Green
2018-05-08 4:29 ` [dpdk-dev] [PATCH 04/18] drivers: net: axgbe: fix broken eeprom string comp Andy Green
2018-05-08 4:29 ` [dpdk-dev] [PATCH 05/18] drivers: net: nfp: nfpcore: fix strncpy misuse Andy Green
2018-05-08 8:58 ` Bruce Richardson
2018-05-08 9:00 ` Andy Green
2018-05-08 9:03 ` Bruce Richardson
2018-05-08 4:29 ` [dpdk-dev] [PATCH 06/18] drivers: net: nfp: nfpcore fix off-by-one and no NUL on strncpy use Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 07/18] drivers: net: nfp: don't memcpy out of source range Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 08/18] drivers: net: nfp: fix buffer overflow in fw_name Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL Andy Green
2018-05-08 17:59 ` Shaikh, Shahed
2018-05-08 19:53 ` Bruce Richardson
2018-05-08 20:02 ` Shaikh, Shahed
2018-05-08 22:07 ` Andy Green
2018-05-08 23:33 ` Shaikh, Shahed
2018-05-08 4:30 ` [dpdk-dev] [PATCH 10/18] drivers: net: qede: fix broken strncpy Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 11/18] drivers:net:sfc: fix strncpy length Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 12/18] drivers: net: sfc: fix another strncpy size and NUL Andy Green
2018-05-08 7:36 ` Andrew Rybchenko
2018-05-08 8:18 ` Andy Green
2018-05-08 9:02 ` Bruce Richardson
2018-05-08 9:08 ` Andrew Rybchenko
2018-05-08 4:30 ` [dpdk-dev] [PATCH 13/18] drivers: net: vdev: readlink inputs cannot be aliased Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 14/18] drivers: net: vdev: fix 3 x strncpy misuse Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 15/18] test-pmd: can't find include Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 16/18] app: fix sprintf overrun bug Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 17/18] app: test-bbdev: strcpy ok for allocated string Andy Green
2018-05-08 4:30 ` [dpdk-dev] [PATCH 18/18] app: test-bbdev: strcpy ok for allocated string 2 Andy Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152575364588.56689.3300796065057551728.stgit@localhost.localdomain \
--to=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).