From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 0E7803230 for ; Tue, 8 May 2018 06:29:59 +0200 (CEST) From: Andy Green To: dev@dpdk.org Date: Tue, 08 May 2018 12:29:28 +0800 Message-ID: <152575364588.56689.3300796065057551728.stgit@localhost.localdomain> User-Agent: StGit/unknown-version Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] [PATCH 00/18] Fix build on gcc8 and various bugs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 04:30:00 -0000 The following series gets current master able to build on Fedora 28 + x86_64 using gcc 8.0.1. There were a number of build-breaking problems, mostly around correct string processing but all of them reflecting some issue in the code. Of the two major issues, one around struct alignment in dpaa I think is properly fixed by the patch 3/18 here, but for the apparently broken hash function cast in 1/18 I just stopped it breaking the build; unless I miss the trick it seems it needs fixing properly after some further discussion. Because of the kind of widespread string processing / off-by-one / buffer overflow issue fixed here, I think it'd be a really good idea to run this stuff through Coverity. They will give you a free account for OSS projects here https://scan.coverity.com/ --- Andy Green (18): lib: ret_table: workaround hash function cast error drivers: bus: pci: fix strncpy dangerous code drivers: bus: dpaa: fix inconsistent struct alignment drivers: net: axgbe: fix broken eeprom string comp drivers: net: nfp: nfpcore: fix strncpy misuse drivers: net: nfp: nfpcore fix off-by-one and no NUL on strncpy use drivers: net: nfp: don't memcpy out of source range drivers: net: nfp: fix buffer overflow in fw_name drivers: net: qede: fix strncpy constant and NUL drivers: net: qede: fix broken strncpy drivers:net:sfc: fix strncpy length drivers: net: sfc: fix another strncpy size and NUL drivers: net: vdev: readlink inputs cannot be aliased drivers: net: vdev: fix 3 x strncpy misuse test-pmd: can't find include app: fix sprintf overrun bug app: test-bbdev: strcpy ok for allocated string app: test-bbdev: strcpy ok for allocated string 2 app/proc-info/main.c | 9 +++++++-- app/test-bbdev/test_bbdev_vector.c | 5 +++-- app/test-pmd/Makefile | 1 + drivers/bus/dpaa/base/qbman/qman.c | 14 +++++++------- drivers/bus/dpaa/include/fsl_qman.h | 24 +++++++++++++----------- drivers/bus/pci/linux/pci.c | 3 ++- drivers/net/axgbe/axgbe_phy_impl.c | 4 ++-- drivers/net/nfp/nfp_net.c | 4 ++-- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ++- drivers/net/nfp/nfpcore/nfp_resource.c | 6 +++--- drivers/net/qede/base/ecore_int.c | 10 ++++++---- drivers/net/qede/qede_main.c | 3 ++- drivers/net/sfc/sfc_ethdev.c | 9 ++++++--- drivers/net/vdev_netvsc/vdev_netvsc.c | 16 ++++++++++------ lib/librte_table/rte_table_hash_cuckoo.c | 2 +- 15 files changed, 67 insertions(+), 46 deletions(-) --