DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 00/18] Fix build on gcc8 and various bugs
Date: Wed, 09 May 2018 09:30:50 +0800	[thread overview]
Message-ID: <152582834896.6809.14521072557832633661.stgit@localhost.localdomain> (raw)

The following series gets current master able to build
on Fedora 28 + x86_64 using gcc 8.0.1.  There were a surprising
number of problems, mostly around correct string processing.

Of the two major issues, one around struct alignment in
dpaa I think is properly fixed by the patch 3/18 here,
but for the apparently broken hash function cast in 1/18
I just stopped it breaking the build.  It seems others are
working on a proper solution for it.

This version of the series incorporates comments from the list
and replaces the broken strncpy() with strlcpy(), adding the
necessary include as needed.

---

Andy Green (18):
      lib/libtre_table: workaround hash function cast error
      drivers/bus/pci: fix strncpy dangerous code
      drivers/bus/dpaa: fix inconsistent struct alignment
      drivers/net/axgbe: fix broken eeprom string comp
      drivers/net/nfp/nfpcore: fix strncpy misuse
      drivers/net/nfp/nfpcore: fix off-by-one and no NUL on strncpy use
      drivers/net/nfp: don't memcpy out of source range
      drivers/net/nfp: fix buffer overflow in fw_name
      drivers/net/qede: fix strncpy constant and NUL
      drivers/net/qede: fix broken strncpy
      drivers/net/sfc: fix strncpy length
      drivers/net/sfc: fix strncpy size and NUL
      drivers/net/vdev: readlink inputs cannot be aliased
      drivers/net/vdev: fix 3 x strncpy misuse
      app/test-pmd: can't find include
      app/proc-info: fix sprintf overrun bug
      app/test-bbdev: test-bbdev: strcpy ok for allocated string
      app/test-bbdev: strcpy ok for allocated string


 app/proc-info/main.c                       |    9 +++++++--
 app/test-bbdev/test_bbdev_vector.c         |    5 +++--
 app/test-pmd/Makefile                      |    1 +
 drivers/bus/dpaa/base/qbman/qman.c         |   14 +++++++-------
 drivers/bus/dpaa/include/fsl_qman.h        |   24 +++++++++++++-----------
 drivers/bus/pci/linux/pci.c                |    2 +-
 drivers/net/axgbe/axgbe_phy_impl.c         |    4 ++--
 drivers/net/nfp/nfp_net.c                  |    4 ++--
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |    4 +++-
 drivers/net/nfp/nfpcore/nfp_resource.c     |    8 +++++---
 drivers/net/qede/base/ecore_int.c          |    8 +++++---
 drivers/net/qede/qede_main.c               |    7 ++++---
 drivers/net/sfc/sfc_ethdev.c               |    6 +++---
 drivers/net/vdev_netvsc/vdev_netvsc.c      |   15 +++++++++------
 lib/librte_table/rte_table_hash_cuckoo.c   |    2 +-
 15 files changed, 66 insertions(+), 47 deletions(-)

--
Signature

             reply	other threads:[~2018-05-09  1:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09  1:30 Andy Green [this message]
2018-05-09  1:30 ` [dpdk-dev] [PATCH v2 01/18] lib/libtre_table: workaround hash function cast error Andy Green
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 02/18] drivers/bus/pci: fix strncpy dangerous code Andy Green
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 03/18] drivers/bus/dpaa: fix inconsistent struct alignment Andy Green
2018-05-09  8:06   ` Hemant Agrawal
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 04/18] drivers/net/axgbe: fix broken eeprom string comp Andy Green
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 05/18] drivers/net/nfp/nfpcore: fix strncpy misuse Andy Green
2018-05-09  9:49   ` Alejandro Lucero
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 06/18] drivers/net/nfp/nfpcore: fix off-by-one and no NUL on strncpy use Andy Green
2018-05-09  9:53   ` Alejandro Lucero
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 07/18] drivers/net/nfp: don't memcpy out of source range Andy Green
2018-05-09  9:54   ` Alejandro Lucero
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 08/18] drivers/net/nfp: fix buffer overflow in fw_name Andy Green
2018-05-09 10:04   ` Alejandro Lucero
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 09/18] drivers/net/qede: fix strncpy constant and NUL Andy Green
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 10/18] drivers/net/qede: fix broken strncpy Andy Green
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 11/18] drivers/net/sfc: fix strncpy length Andy Green
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 12/18] drivers/net/sfc: fix strncpy size and NUL Andy Green
2018-05-09  1:31 ` [dpdk-dev] [PATCH v2 13/18] drivers/net/vdev: readlink inputs cannot be aliased Andy Green
2018-05-09 15:33   ` Stephen Hemminger
2018-05-09  1:32 ` [dpdk-dev] [PATCH v2 14/18] drivers/net/vdev: fix 3 x strncpy misuse Andy Green
2018-05-09  1:32 ` [dpdk-dev] [PATCH v2 15/18] app/test-pmd: can't find include Andy Green
2018-05-09  1:32 ` [dpdk-dev] [PATCH v2 16/18] app/proc-info: fix sprintf overrun bug Andy Green
2018-05-09  1:32 ` [dpdk-dev] [PATCH v2 17/18] app/test-bbdev: test-bbdev: strcpy ok for allocated string Andy Green
2018-05-09  1:32 ` [dpdk-dev] [PATCH v2 18/18] app/test-bbdev: " Andy Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152582834896.6809.14521072557832633661.stgit@localhost.localdomain \
    --to=andy@warmcat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).