From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <andy@warmcat.com> Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 12D4B1B6DF for <dev@dpdk.org>; Thu, 10 May 2018 04:46:43 +0200 (CEST) From: Andy Green <andy@warmcat.com> To: dev@dpdk.org Date: Thu, 10 May 2018 10:46:39 +0800 Message-ID: <152592039932.119328.8808609381281807698.stgit@localhost.localdomain> In-Reply-To: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> References: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> User-Agent: StGit/unknown-version Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] [PATCH v3 04/40] drivers/net/nfp/nfpcore: fix strncpy misuse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 10 May 2018 02:46:44 -0000 Signed-off-by: Andy Green <andy@warmcat.com> Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com> Tested-by: Alejandro Lucero <alejandro.lucero@netronome.com> --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c index 4e6c66624..52b294888 100644 --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c @@ -31,6 +31,8 @@ #include <sys/file.h> #include <sys/stat.h> +#include <rte_string_fns.h> + #include "nfp_cpp.h" #include "nfp_target.h" #include "nfp6000/nfp6000.h" @@ -846,7 +848,7 @@ nfp6000_init(struct nfp_cpp *cpp, const char *devname) memset(desc->busdev, 0, BUSDEV_SZ); - strncpy(desc->busdev, devname, strlen(devname)); + strlcpy(desc->busdev, devname, sizeof(desc->busdev)); ret = nfp_acquire_process_lock(desc); if (ret)