From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 13/24] rte_mbuf.h: make sure RTE-MIN compares same types
Date: Fri, 11 May 2018 09:59:59 +0800 [thread overview]
Message-ID: <152600399988.54839.2533082150425969285.stgit@localhost.localdomain> (raw)
In-Reply-To: <152600382101.54839.18392182958431211001.stgit@localhost.localdomain>
/projects/lagopus/src/dpdk/build/include/rte_common.h:384:2:
warning: conversion from 'int' to 'uint16_t'
{aka 'short unsigned int'} may change value [-Wconversion]
__extension__ ({ \
^~~~~~~~~~~~~
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h:1204:16:
note: in expansion of macro 'RTE_MIN'
m->data_off = RTE_MIN(RTE_PKTMBUF_HEADROOM,
(uint16_t)m->buf_len);
RTE_PKTMBUF_HEADROOM is typ 128, so it doesn't make trouble.
Signed-off-by: Andy Green <andy@warmcat.com>
---
lib/librte_mbuf/rte_mbuf.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index c214f1945..a27dbb878 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1201,7 +1201,8 @@ rte_pktmbuf_priv_size(struct rte_mempool *mp)
*/
static inline void rte_pktmbuf_reset_headroom(struct rte_mbuf *m)
{
- m->data_off = RTE_MIN(RTE_PKTMBUF_HEADROOM, (uint16_t)m->buf_len);
+ m->data_off = (uint16_t)RTE_MIN((uint16_t)RTE_PKTMBUF_HEADROOM,
+ (uint16_t)m->buf_len);
}
/**
next prev parent reply other threads:[~2018-05-11 2:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 1:58 [dpdk-dev] [PATCH v2 00/24] Fixes for GCC8 against lagopus Andy Green
2018-05-11 1:58 ` [dpdk-dev] [PATCH v2 01/24] lib/librte_eal: import libbsd strlcpy Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 02/24] lib/librte_ethdev: change eth-dev-ops API to return int Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 03/24] rte_common.h: cast gcc builtin result to avoid complaints Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 04/24] lib/librte_eal: explicit tmp cast Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 05/24] lib/librte_eal: explicit cast for signed change Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 06/24] /lib/librte_eal: stage cast from uint64 to long Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 07/24] rte_spinlock.h: stack declarations before code Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 08/24] rte_ring_generic.h: " Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 09/24] rte_ring.h: remove signed type flipflopping Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 10/24] rte_dev.h: stack declaration at top of own basic block Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 11/24] rte_mbuf.h: avoid warnings from inadvertant promotion Andy Green
2018-05-11 1:59 ` [dpdk-dev] [PATCH v2 12/24] rte_mbuf.h: explicit casts for int16 to uint16 Andy Green
2018-05-11 1:59 ` Andy Green [this message]
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 14/24] rte_mbuf.h: explicit cast restricting ptrdiff " Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 15/24] rte_mbuf.h: explicit cast for size type to uint32 Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 16/24] rte_mbuf.h: explicit casts to uint16 to avoid warnings Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 17/24] rte_byteorder.h: explicit cast for return promotion Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 18/24] rte_ether.h: explicit cast avoiding truncation warning Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 19/24] rte_ether.h: stack vars declared at top of function Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 20/24] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 21/24] rte_ethdev.h: explicit cast for truncation Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 22/24] rte_hash_crc.h: stack vars declared at top of function Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 23/24] rte_hash_crc.h: explicit casts for truncation Andy Green
2018-05-11 2:00 ` [dpdk-dev] [PATCH v2 24/24] test_table_pipeline: repair munged indirection level Andy Green
2018-05-11 3:04 ` [dpdk-dev] [PATCH v2 00/24] Fixes for GCC8 against lagopus Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152600399988.54839.2533082150425969285.stgit@localhost.localdomain \
--to=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).