From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <andy@warmcat.com>
Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82])
by dpdk.org (Postfix) with ESMTP id D54691CFB3
for <dev@dpdk.org>; Sun, 13 May 2018 03:35:40 +0200 (CEST)
From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org
Date: Sun, 13 May 2018 09:35:17 +0800
Message-ID: <152617531727.68145.12744668569801299577.stgit@localhost.localdomain>
User-Agent: StGit/unknown-version
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: [dpdk-dev] [PATCH] rte_eal_version_map: export rte-strlcpy
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 13 May 2018 01:35:41 -0000
Building dpdk as a shared library on systems without their own
native strlcpy (eg, glibc) fails, because we do not allow the
explicit export of the helper rte_strlcpy().
It used to be an inline, but it's now a function. Building
static, there's no problem but configured to build shared, the
users of rte_strlcpy() cannot bind to the definition in
librte_eal even though they give the library on their linker
line, because it's not listed to be exported.
This must also be applied if
lib/librte_eal: import libbsd strlcpy
is applied to allow shared build.
BTW this is a clear instance where nothing else will do but
use the api name on the commit title...
Signed-off-by: Andy Green <andy@warmcat.com>
---
lib/librte_eal/rte_eal_version.map | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 859723974..9d5b67903 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -241,6 +241,7 @@ DPDK_18.05 {
rte_service_set_runstate_mapped_check;
rte_service_set_stats_enable;
rte_service_start_with_defaults;
+ rte_strlcpy;
} DPDK_18.02;