From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com
[209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 699242BB0
for <dev@dpdk.org>; Tue, 11 Apr 2017 14:50:16 +0200 (CEST)
Received: by mail-wr0-f177.google.com with SMTP id l28so38684628wre.0
for <dev@dpdk.org>; Tue, 11 Apr 2017 05:50:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=CltF0QJKQWhirhxohDuSgC9IXSGsydHwP7FCAU/Jo6g=;
b=ZiNVa88Qy9TbgEO1hYQmHZ2e4iAMDrN3Xlmfg8q38PxYybkYj2dOZ1yy86IjP/1TvZ
yGNev81+1fuWAbGvKxueUBUODxjvKy3ksifCAhMgMM3cIBgVCPhRYgPM7c8x/PPuJk1H
liVtv2rV809wypnhGqfCqfxUxRAafrpS508avOIitHaNF71CRfai9xyBe6ZjVQWt9L0r
npKPnsjWTUO+INEvo6YDvnZvdl9BhMAMiL02bwIgTPVBT7tBtDkhnEG6E91QCuGvLB5v
1ffn4tKODrfWCooRdenISv+SI0FpGYok8xzmx/2AfCgkmoLHGMN/OS0nZBpKTvTSyaV/
iL6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=CltF0QJKQWhirhxohDuSgC9IXSGsydHwP7FCAU/Jo6g=;
b=dU1XSWwURvmSgeDuyUktAFRX3AckaOcZZmEJSliMbBvF9Mey9elfpNfMk9oXylsnJI
NFg0jX8FpzIcVJV/C99tbnRgAHxWGi/wqAJgel3u3ECy7FlS6Ik/lHGKYt6KyxKLp4Ma
jWPrUfT5LX94gjXc5M4Ku2Yt3CQuxIgs2Y2ttzN2e8zIHl+0kdNXjWY3lMHI57bgPihF
T2CDTBTmb7Oc5ZdCacV30C0hQSV6cqcs1PAkLd4x4/2XwC7F4psHlX8mFex8DbkfBa1X
EkSwb65+J+xbpISriyyw1FN1hLABYw65ZtDAYv6B8W+xmya7ZQb5Y+jiOy8z0wM3e8sb
uF9g==
X-Gm-Message-State: AN3rC/7EWsIfa5kt5VMyRo5KhkxeNc1FWefc64248RbQXbTypc6oAPa2bb92mfdFT3V/rYf4
X-Received: by 10.223.170.143 with SMTP id h15mr14938572wrc.64.1491915016152;
Tue, 11 Apr 2017 05:50:16 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
by smtp.gmail.com with ESMTPSA id 24sm21450712wrw.46.2017.04.11.05.50.15
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 11 Apr 2017 05:50:15 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
Olivier MATZ <olivier.matz@6wind.com>, dev@dpdk.org, shreyansh.jain@nxp.com
Date: Tue, 11 Apr 2017 14:50:14 +0200
Message-ID: <1526541.obk11Y6NX2@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <5f4fe240-8f17-0d4f-04b7-a8dd04b2c16e@intel.com>
References: <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com>
<21940728.tivBTtkBCF@xps13> <5f4fe240-8f17-0d4f-04b7-a8dd04b2c16e@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] mempool/dpaa2: add DPAA2 hardware
offloaded mempool
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Apr 2017 12:50:16 -0000
2017-04-11 09:39, Ferruh Yigit:
> On 4/11/2017 8:50 AM, Thomas Monjalon wrote:
> > 2017-04-11 11:28, Hemant Agrawal:
> >> On 4/11/2017 1:28 AM, Olivier MATZ wrote:
> >>> Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >>>> --- a/drivers/bus/Makefile
> >>>> +++ b/drivers/bus/Makefile
> >>>> @@ -33,6 +33,10 @@ include $(RTE_SDK)/mk/rte.vars.mk
> >>>>
> >>>> core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether
> >>>>
> >>>> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL),y)
> >>>> +CONFIG_RTE_LIBRTE_FSLMC_BUS = $(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL)
> >>>> +endif
> >>>> +
> >>>> DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc
> >>>> DEPDIRS-fslmc = ${core-libs}
> >>>>
> >>>
> >>> What's the purpose of this?
> >>> Not sure we are allowed to modify the configs in the Makefiles.
> >>
> >> DPAA2_MEMPOOL will not work without the DPAA2 mempool hw instance
> >> detected on FSLMC_BUS.
> >> So, it is required that if you are enabling DPAA2_MEMPOOL, FSLMC_BUS is
> >> to be enabled.
> >>
> >> Currently the config structure do not provide such dependency definitions.
> >>
> >> This was done based on the suggestions on the initial patches from
> >> Ferruh and Jerin.
> >
> > Please do not do that.
> > We do not change the configuration in the back of the user.
> > This kind of dependency should be managed in the configuration step
> > which do not exist yet.
> >
> > You can use $(error) to stop the compilation instead.
>
> As Hemant mentioned, this was my suggestion. There is a configuration
> dependency here, that we don't have a way to resolve in dpdk.
>
> If one of the end leaf selected, it makes sense to me to auto select
> dependent pieces.
A dependency must be solved at configuration time with appropriate
user notification.
For now, we just check them at compilation time and throw an error.