From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 345101B68F
for <dev@dpdk.org>; Mon, 29 Jan 2018 12:52:57 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id A9B0920AE6;
Mon, 29 Jan 2018 06:52:56 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
by compute1.internal (MEProxy); Mon, 29 Jan 2018 06:52:56 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=oA4bmA7XFXtT3ZBg1uoHtiPshw
Voym3aYDy86JFpZpk=; b=ept/S8Go35E30vPfeqyCumzpH1JcUDbNbZ/SHMaRFZ
uTpFW8Oi5NZooOBFUDO3tdztvMNHLNxSC0fOqZmDmhqrij9w5G8CjErMpaa2z55w
J0dxadn/nuXY4T+KngE4iS4MOaLHz952FoOEAB4hyblvGcXE6cqo4qfaDsgq00W7
g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=oA4bmA
7XFXtT3ZBg1uoHtiPshwVoym3aYDy86JFpZpk=; b=Q/MNvPQ8cB021MLlyrp40z
P+XRpF5rrx+ExPUN0G3wpvfNXfH67MWsLY8Jof1Cu+Ual9hEyr0yKIueZ3coILLq
rjP9dXxBTV9mA5f7CEh49UMSMWyNUhDBvQTPmPW/8TCvS2gL8PMNUfQe7mY64afc
Dq6yoqAGRQqnhZSku79h8KzYJt4CQpAo7dHf72oewQ/zfZa9VOnowgkMTU7y0lI0
dDrOAzGicsLdPCSpGdizTLHagjAizrQMQAhPoxHxvp4ShkyDZxali0WwwWl0Lq0F
e0JGoI2yNn6qROS6bGNHMMZ60u1JUZ6ZftOaQu8uokRUuaEQFYE1+ZHWfYOWhhnw
==
X-ME-Sender: <xms:GAtvWkJyYNuIOwaBsF3SZjdzcEmgTzJ8bptE9c-6fD2N76cWrTTgzQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 570A524724;
Mon, 29 Jan 2018 06:52:56 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: wenzhuo.lu@intel.com, ferruh.yigit@intel.com
Cc: Moti Haimovsky <motih@mellanox.com>, dev@dpdk.org
Date: Mon, 29 Jan 2018 12:52:10 +0100
Message-ID: <1526570.x4yMYrLSQg@xps>
In-Reply-To: <1517225598-132061-1-git-send-email-motih@mellanox.com>
References: <1516695081-178919-1-git-send-email-motih@mellanox.com>
<1517225598-132061-1-git-send-email-motih@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: do not enable Rx offloads by
default
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2018 11:52:57 -0000
29/01/2018 12:33, Moti Haimovsky:
> Removed the hardcoded preconfigured Rx offload configuration from
> testpmd and changed the Rx offload command line parameters from
> disable to enable.
> Testers who wish to use these offloads will now have to explicitly
> write them in the command-line when running testpmd.
>
> Motivation:
> Some PMDs such at the mlx4 may not implement all the offloads.
> After the offload API rework assuming no offload is enabled by default,
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying
> to enable a not supported offload is clearly an error which will cause
> configuration failing.
>
> Considering that testpmd is an application to test the PMD, it should
> not fail on a configuration which was not explicitly requested.
> The behavior of this test application is then turned to an opt-in
> model.
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
This is a very good step in the right direction
because testpmd is a tool app.
So testpmd must not enable anything without explicit user request.
The next step will be to check the offload capabilities
before enabling them.
If a requested capability is not available, it should return
either an error, or a warning.
I want to merge this first patch in 18.02-rc2,
because some drivers (lacking some capabilities) cannot be tested
without explicitly disabling the forced offloads.