From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] ring: fix sign conversion warning
Date: Mon, 28 May 2018 10:29:10 +0800 [thread overview]
Message-ID: <152747455078.35192.13318975337563776910.stgit@localhost.localdomain> (raw)
In-Reply-To: <152747443129.35192.15673273827095899997.stgit@localhost.localdomain>
On gcc 5.4.0 / native aarch64 from Ubuntu 16.04:
/home/agreen/lagopus/src/dpdk/build/include/rte_ring.h:
In function '__rte_ring_do_dequeue':
/home/agreen/lagopus/src/dpdk/build/include/rte_ring.h:
385:35: warning: conversion to 'int' from 'unsigned int'
may change the sign of the result [-Wsign-conversion]
n = __rte_ring_move_cons_head(r, is_sc, n, behavior,
^
Signed-off-by: Andy Green <andy@warmcat.com>
Fixes: e8ed5056c8 ("ring: remove signed type flip-flopping")
^
---
lib/librte_ring/rte_ring.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index 124582251..de1a5f366 100644
--- a/lib/librte_ring/rte_ring.h
+++ b/lib/librte_ring/rte_ring.h
@@ -382,7 +382,7 @@ __rte_ring_do_dequeue(struct rte_ring *r, void **obj_table,
uint32_t cons_head, cons_next;
uint32_t entries;
- n = __rte_ring_move_cons_head(r, is_sc, n, behavior,
+ n = __rte_ring_move_cons_head(r, (int)is_sc, n, behavior,
&cons_head, &cons_next, &entries);
if (n == 0)
goto end;
next prev parent reply other threads:[~2018-05-28 2:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 2:29 [dpdk-dev] [PATCH 0/2] dpdk header fixes for aarch64 Andy Green
2018-05-28 2:29 ` [dpdk-dev] [PATCH 1/2] ring: fix declaration after code Andy Green
2018-05-28 8:15 ` Gavin Hu
2018-05-28 8:46 ` Andy Green
2018-05-28 8:54 ` Gavin Hu
2018-05-28 2:29 ` Andy Green [this message]
2018-05-28 9:03 ` [dpdk-dev] [PATCH v2 0/2] dpdk header fixes for aarch64 Andy Green
2018-05-28 9:03 ` [dpdk-dev] [PATCH v2 1/2] ring: fix declaration after code Andy Green
2018-07-16 7:15 ` Olivier Matz
2018-05-28 9:03 ` [dpdk-dev] [PATCH v2 2/2] ring: fix sign conversion warning Andy Green
2018-07-16 7:16 ` Olivier Matz
2018-07-26 13:30 ` [dpdk-dev] [PATCH v2 0/2] dpdk header fixes for aarch64 Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152747455078.35192.13318975337563776910.stgit@localhost.localdomain \
--to=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).