From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 9EFC12BAC for ; Mon, 28 May 2018 08:50:54 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 205AEB4006A; Mon, 28 May 2018 06:50:53 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sun, 27 May 2018 23:50:50 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25 via Frontend Transport; Sun, 27 May 2018 23:50:50 -0700 Received: from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com [10.17.10.10]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w4S6omCp024262; Mon, 28 May 2018 07:50:49 +0100 Received: from uklogin.uk.solarflarecom.com (localhost.localdomain [127.0.0.1]) by uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w4S6om9I023357; Mon, 28 May 2018 07:50:48 +0100 From: Andrew Rybchenko To: CC: Thomas Monjalon , Ferruh Yigit Date: Mon, 28 May 2018 07:50:47 +0100 Message-ID: <1527490247-23324-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.2.3 MIME-Version: 1.0 Content-Type: text/plain X-MDID: 1527490253-uBxzHf6+Fc7b Subject: [dpdk-dev] [PATCH] net/sfc: add missing Rx descriptor status callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2018 06:50:54 -0000 Rx descriptor status callback was lost and request of the Rx descriptor status crashes application if equal stride super-buffer Rx mode is used. Fixes: 390f9b8d82c9 ("net/sfc: support equal stride super-buffer Rx mode") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef10_essb_rx.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c index 289b61e52..5f5af602c 100644 --- a/drivers/net/sfc/sfc_ef10_essb_rx.c +++ b/drivers/net/sfc/sfc_ef10_essb_rx.c @@ -413,6 +413,14 @@ sfc_ef10_essb_rx_qdesc_npending(__rte_unused struct sfc_dp_rxq *dp_rxq) return -ENOTSUP; } +static sfc_dp_rx_qdesc_status_t sfc_ef10_essb_rx_qdesc_status; +static int +sfc_ef10_essb_rx_qdesc_status(__rte_unused struct sfc_dp_rxq *dp_rxq, + __rte_unused uint16_t offset) +{ + return -ENOTSUP; +} + static sfc_dp_rx_get_dev_info_t sfc_ef10_essb_rx_get_dev_info; static void sfc_ef10_essb_rx_get_dev_info(struct rte_eth_dev_info *dev_info) @@ -687,5 +695,6 @@ struct sfc_dp_rx sfc_ef10_essb_rx = { .qpurge = sfc_ef10_essb_rx_qpurge, .supported_ptypes_get = sfc_ef10_supported_ptypes_get, .qdesc_npending = sfc_ef10_essb_rx_qdesc_npending, + .qdesc_status = sfc_ef10_essb_rx_qdesc_status, .pkt_burst = sfc_ef10_essb_recv_pkts, }; -- 2.17.0