From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 95D836849 for <dev@dpdk.org>; Fri, 3 Jul 2015 21:53:28 +0200 (CEST) Received: by wicgi11 with SMTP id gi11so107620051wic.0 for <dev@dpdk.org>; Fri, 03 Jul 2015 12:53:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=iWGktPnO/ckcQc/IBowo8eztBB1VL9C+fefrNV4fg6I=; b=jwK0flN1qMsUncAWPsRjS5veJh8d5Oh/ZnELpi63Eqv/lLl3lmhv6GHJiMTqJAPqvc VaOc6GrMCvEuqz2SiK0QtlErrGO7sUXPOBSgNCWF3O29X6uylBvgPyOdahPiAi16XKbi MRm2Ty1qtM9vBhyyM9QWWY9k5CRtb1vN2tG/PdTNoRuBgtVDb/FjcPt4ulfQu3fvO5yj cq/SObyLuu8/nDRw2u8lCK30a+7/NbTWWMa/wsIjrsoL5TNIekDaLshqdoDJpSHhhTOS A9UYKL6QVyiP3rQpUEI2owm8YMAMsSlrSYUy67DbMX47bi5kYPa3rdII8AMoLTPDC3ya bhiQ== X-Gm-Message-State: ALoCoQnTWalv3MKuQXAmIzZ3gSMy4yvzL/sQK3JBJM5wI8lkuCht20N0/hPLWtH8yR2sBGRNVjc6 X-Received: by 10.194.200.73 with SMTP id jq9mr23257988wjc.52.1435953208284; Fri, 03 Jul 2015 12:53:28 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id jy6sm14826598wjc.4.2015.07.03.12.53.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jul 2015 12:53:27 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Bruce Richardson <bruce.richardson@intel.com> Date: Fri, 03 Jul 2015 21:52:17 +0200 Message-ID: <15281259.4jgDbnvX5x@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150703160425.GC8096@bricha3-MOBL3> References: <1435938006-22254-1-git-send-email-bruce.richardson@intel.com> <1879755.kzD1mjHoUo@xps13> <20150703160425.GC8096@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: check mbuf refcnt when clearing RX/TX ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 03 Jul 2015 19:53:28 -0000 2015-07-03 17:04, Bruce Richardson: > On Fri, Jul 03, 2015 at 05:46:55PM +0200, Thomas Monjalon wrote: > > 2015-07-03 16:40, Bruce Richardson: > > > The function to clear the TX ring when a port was being closed, e.g. on > > > exit in testpmd, was not checking the mbuf refcnt before freeing it. > > > Since the function in the vector driver to clear the ring after TX does > > > not set the pointer to NULL post-free, this caused crashes if mbuf > > > debugging was turned on. > > > > Please, could you add a Fixes: line to reference the origin of the bug? > > Thanks > > What benefit does that information provide? Given that this bug occurs in > two places in the code, and has been there for some time, I'm not sure that a > straight lookup of the commit that last changed the line(s) would identify the > true source of the bug. Because of that, I'd like to know the information is > really going to be useful before making an effort to track it down. :-) If it fixes a bug which was in previous release, it may deserve to be in the release notes. It also helps people wanting to fix the old version they are stuck with. Given it fixes only a crash in debug mode, it's not so important here.