From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dariuszx.stojaczyk@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 23286A48C;
Fri, 8 Jun 2018 10:56:07 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
08 Jun 2018 01:56:07 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,490,1520924400"; d="scan'208";a="62360875"
Received: from kraken.imu.intel.com (HELO Sent) ([10.217.246.153])
by fmsmga001.fm.intel.com with SMTP; 08 Jun 2018 01:56:05 -0700
Received: by Sent (sSMTP sendmail emulation); Fri, 08 Jun 2018 14:41:27 +0200
From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
To: dev@dpdk.org
Cc: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, olivier.matz@6wind.com,
stable@dpdk.org
Date: Fri, 8 Jun 2018 14:37:07 +0200
Message-Id: <1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com>
References: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com>
Subject: [dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for
rte_ctrl_thread_create()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 08:56:09 -0000
This function returned positive error numbers instead
of negative ones as desbribed in the doc. What's worse,
multiple of its callers only check for (rc < 0) to detect
failure.
It was incorrectly assumed that pthread_create
and pthread_setaffinity_np return negative errnos. They
always returns positive ones, so this patch negates their
return values before returning.
Fixes: 9e5afc72c909 ("eal: add function to create control threads")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
---
lib/librte_eal/common/eal_common_thread.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 8110ac2..48ef4d6 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -175,7 +175,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
params = malloc(sizeof(*params));
if (!params)
- return -1;
+ return -ENOMEM;
params->start_routine = start_routine;
params->arg = arg;
@@ -185,7 +185,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
if (ret != 0) {
free(params);
- return ret;
+ return -ret;
}
if (name != NULL) {
@@ -228,5 +228,5 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
}
pthread_cancel(*thread);
pthread_join(*thread, NULL);
- return ret;
+ return -ret;
}
--
2.7.4