From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3784A04B1; Mon, 5 Oct 2020 19:44:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F6741B733; Mon, 5 Oct 2020 19:44:02 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 782681B70F for ; Mon, 5 Oct 2020 19:44:01 +0200 (CEST) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 095HWPoD192205; Mon, 5 Oct 2020 13:43:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=8p4Xmylk8StkAEtPJNVvjH28qbJN+gvOZOpdnYzEPIg=; b=P2VlPEd2Sl3GzslPrPslCsOxMamx1K7mx6cKOKIM4Jkg7AP3RX6TEujvQA8R43zTmsJN gMieXaZe49sEDbjuz6/+5n+WwzGIjlFx3KjpOk5ayLRE3L9rzxZ7CvWqBrD+q16sR7xl GDQpOryOJQVFvTGVx3pWRaEyY4GoIX3nelf8N3d7EAoLi+otyEKoUfw1zyVduivAoYV7 n/ZegUJCPqO+QCRQmepBe0aWEF4vdZ4A5B+bh4TGt+6RO6pt/X8Klu1pDpUGmdBc4N+Y xbaBOJGCS+C4bNy0hh14CRE6gXBGXHlHmGrd3cZfskO5YXnT+TFh7HTCtLyYuGoV/szN 0w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 34078esyyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Oct 2020 13:43:59 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 095HWQfA192339; Mon, 5 Oct 2020 13:43:58 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 34078esyxw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Oct 2020 13:43:58 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 095HgXm8031548; Mon, 5 Oct 2020 17:43:57 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma04dal.us.ibm.com with ESMTP id 33xgx95mhu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Oct 2020 17:43:57 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 095Hhuev54264126 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Oct 2020 17:43:56 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9FD3F112061; Mon, 5 Oct 2020 17:43:56 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70601112062; Mon, 5 Oct 2020 17:43:55 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.211.110.122]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 5 Oct 2020 17:43:54 +0000 (GMT) To: Maxime Coquelin , "Xia, Chenbo" , "Wang, Zhihong" , "dev@dpdk.org" References: <20200902170309.16513-1-drc@linux.vnet.ibm.com> <6f325c96-beca-fe9c-0622-90a8a6522e0c@redhat.com> From: David Christensen Message-ID: <1528760c-72ad-829b-ac43-7182ac848da4@linux.vnet.ibm.com> Date: Mon, 5 Oct 2020 10:43:53 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <6f325c96-beca-fe9c-0622-90a8a6522e0c@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-05_12:2020-10-05, 2020-10-05 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 impostorscore=0 phishscore=0 mlxscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1011 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010050126 Subject: Re: [dpdk-dev] [PATCH] net/vhost: fix xstats wrong after clearing stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/20 1:07 AM, Maxime Coquelin wrote: > Hi David, > > Could you please post a v2 with Chenbo's comments taken into account? Sorry, been out of the office for a bit but now working through my backlog. I did make the change but discovered there were additional dependencies between stats and xstats that weren't addressed in the v1 patch, specifically per queue packet/byte counters: $ diff before.txt after.txt: < tx_good_packets: 24769339 --- > tx_good_packets: 0 6c6 < tx_good_bytes: 1501282012967 --- > tx_good_bytes: 0 14,15c14,15 < tx_q0packets: 24769339 < tx_q0bytes: 1501282012967 --- > tx_q0packets: 0 > tx_q0bytes: 0 51c51 < tx_good_packets: 2653125 --- > tx_good_packets: 0 53c53 < tx_good_bytes: 167404266 --- > tx_good_bytes: 0 61,62c61,62 < tx_q0packets: 2653125 < tx_q0bytes: 167404266 --- > tx_q0packets: 0 > tx_q0bytes: 0 I'm looking at how to address these as well for a v2 patch soon. Dave