From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Anoob.Joseph@cavium.com>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
(mail-sn1nam02on0049.outbound.protection.outlook.com [104.47.36.49])
by dpdk.org (Postfix) with ESMTP id C5BA01E43E
for <dev@dpdk.org>; Thu, 14 Jun 2018 13:50:25 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=iiA6PdC2rDWACp81Dtj6YEqSpQi+zdrLoKUppo3MYaI=;
b=dfoAq3v9xps6p93Q8LPbB+oSEgsCS7/MGsix8cPilF7AkWYaMBBFvcp7PN0XCRxkRSaBGVWREIQFgZRGnarTbwewchF3T5KtiHb8Vd+P8wfj++Znz/QccS2Icw5nZCOIVQ5Asb3EX3dtx2zyiTrj4VO9JzxIGNTU+MStrE9zkKY=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Anoob.Joseph@cavium.com;
Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2)
by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Thu, 14 Jun
2018 11:50:22 +0000
From: Anoob Joseph <anoob.joseph@caviumnetworks.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: Anoob Joseph <anoob.joseph@caviumnetworks.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org
Date: Thu, 14 Jun 2018 17:19:03 +0530
Message-Id: <1528976946-14396-13-git-send-email-anoob.joseph@caviumnetworks.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com>
References: <1528477766-15788-1-git-send-email-anoob.joseph@caviumnetworks.com>
<1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [115.113.156.2]
X-ClientProxiedBy: PN1PR01CA0095.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::11)
To BN7PR07MB4898.namprd07.prod.outlook.com
(2603:10b6:406:ef::27)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a6b579c3-76fd-4552-4304-08d5d1ed03f6
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(7020095)(4652020)(5600026)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);
SRVR:BN7PR07MB4898;
X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898;
3:VZOuz1OSLsmjqJvXTAsMO1ZgWpA+DSCMRifIWyun1dEBAdM6tOKsI1tpFA+q83gjVjhUgbAYA4+cCDxwmPNACYCXRmVLPISzksKRCgnJ4aHWcsDo3ZG7yeWeVvF3T85hu7J8hrrhlj3RrcvVMgJiDANLbZ/LTCEy2YJjNkeMNEK6wiqp14N2R3Ai7pAq92DV7cd4ZUrT7qFbDK7RLduaSBcpz3KNdPtiT3jH5PSk60/D1NKPiwjVa7ygBJ95EVL1;
25:kmUZ3wPijyMgNc5qM28hgsKr4LNC/aeB3I0XjxOxySvOZ4WnMT3AvMuqGbd1qNJb8fki2OKFaDFQR8UkA5QlHpIhB6amwvv43Cny1t+7pMU4mUJX66Wxe6/WJcGccfFb8PSrGW6qmcEpaY5dsyjUNu8/kyptyMBEvXWavQpjL9XPq7FcWgHjFzAU+b9y643R7faagLATcD1ffOIngvziD9NPCgFzSvuVZ+AHSM/37KUYYeCJlQusmkHv3vtWsc1VGscsG7aloQ27RYif+vjza3DGAdYGDg0T9b8RyCwP9Y3LOQDmtzoxG6zecs4hyCJauTgo8m1XHkKViOKNE/T5uQ==;
31:crRQv0TsCYpM5U/gvIvN4RF1R1S0SJCkskgOt6Y+vjQRNv0M/qJA6RVKER0F24SfMuZ4ObQMLsyitVTZKD5pVaLG64f0HlcKsYGppc7V/evzPuctJMm3XtZyEL1+WTCZfF+vJKxX3NnWkZttyZs7HDvHrfGGx3Nos42H8o1vd7KW2mQvMjKOmnI8KUeJSnvwX0a715JnFfL63zYgsvfN62dlYIJkNPbGiZ9s3f/V6EA=
X-MS-TrafficTypeDiagnostic: BN7PR07MB4898:
X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898;
20:8/dDpBtvrbPx6XzIdoO4DKJDnthF13hIJ/j+9jlkW+cMQx/pTyq16B94uHHR7Jv3R4/8tFglbONfAWYAXaH4yeQTM2GtdRh1ahhYAlt1DkO1Hy3i+P7+Pn2wUAs54emZ9SyxWKyoi6XQ+faoeWWrzV6uqo/AfMljy/CAGbnDonS/E0NHX4wNIWVQmy1eUwoIbNPKsTzn7o98biaufBkt+b0cUcpuIWe3+Tu66vYzykhoVjviGxubJAoSFa2yUkjo4Iw5OqNv8iDNviE1AKHImVg74nQ6x0xXrGosuEWZzit4M5yAeYskR9VLdNp+mXhQGOwu6ExPNg5muNNSWWsXoR1KvOIjBAX0YReeK72JW551aCrm04Y4lsvI9+dXrU7mMcCHJQo/KoHQpPVWrS+P1tPTqT7uhRcoB+zxM2TWfLJCcsYf/qYbrZ5MDsgPCRzBWBVE5eTUfZd2NuixpuX0+JGOjkeRk++kDuLZBlDCvMOUOyMzbk4Cni98hcw58UAKRM9CxoS58TYG0g2Z0DXn4ALZDdNJa8PsHu256txPU2DOhy6C0zBqyPX1iAEPl/7jFjWoFHB0jQn9sLzwm9KHt3ubS1qXEvOuMQiJnDrdPnA=;
4:x4XVAz2p5sWdt7nUpEmz1myrCvzoKh4EONvo/l1vQals+1JiP7flhItKQeJrzfPSUpBdsJNnxczydcswl2I/XdK7RPjJOBieAsPJ1EQ509TG+VEhFez6QUZQBzjjUlnmc704wQbmhinB/kprWmaWVaIGB2w0iNeNprCkfutJ1SkGtykFLDUXmN5qeAxLZdKCfzecAe42JHvLLop5HCZ+/+1duAK6Uj3abpN0+fQeqdUebuX1W3t4Zy/NZfdKCYfhq4wVfdGBJ9EuXSEDd/H7Iw==
X-Microsoft-Antispam-PRVS: <BN7PR07MB4898CE36E09C6CDBB6E1D97BF87D0@BN7PR07MB4898.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231254)(944501410)(52105095)(93006095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016);
SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898;
X-Forefront-PRVS: 0703B549E4
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(39860400002)(39380400002)(396003)(376002)(346002)(366004)(199004)(189003)(446003)(956004)(2616005)(305945005)(6666003)(47776003)(476003)(54906003)(44832011)(53936002)(68736007)(486006)(110136005)(8936002)(8676002)(81156014)(16586007)(316002)(81166006)(25786009)(4326008)(7736002)(15650500001)(6116002)(3846002)(11346002)(97736004)(36756003)(106356001)(478600001)(105586002)(42882007)(52116002)(51416003)(26005)(16526019)(186003)(50226002)(66066001)(72206003)(6486002)(2906002)(55236004)(50466002)(575784001)(6512007)(386003)(6506007)(5660300001)(76176011)(48376002);
DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898;
H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en;
PTR:InfoNoRecords; A:1; MX:1;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898;
23:QqG8jPgiyzAvUVKYwTtT/J/vcaeT1vvm3g7uAhLJ2?=
=?us-ascii?Q?+FtrF/A+NKyRPBoENkoOwO0sOu8ihP86UTH1uy1yimf9E/WLYXAALg9N1Nyg?=
=?us-ascii?Q?WkhovTIHI8xn6XJqNCKF/dzBpyz+epXxm1trU9dYogE0BOHqLd7EpFpTHLGL?=
=?us-ascii?Q?g9q+DeH70irGNtANmjJX8YFw+ysMDnwonNAEphXbzIZW28J6XhIb1NFuzk6x?=
=?us-ascii?Q?zSRh6CgpBjD65lgj8BQKMff9a6qmJ2Kp9Occ6HtgStn2bX/E9ui+9eFM9pUz?=
=?us-ascii?Q?Ksqn5xbRp+Nps3ydhDyQwSaMSL9+pP6dz8Wbnh1xlGHxL43tQv6ZIzNiNIST?=
=?us-ascii?Q?o+uXh5EWfxzd/nXh0vjZ0z0/nXj/kbxc6eZmQlUCkuYH51uIO6ZU4RJiw6h7?=
=?us-ascii?Q?/4o1zcdD2cZWgV0i/cHRku+sbyVMXSHSgCR1LtQuBQKy5Qie6eDhST8iMrxy?=
=?us-ascii?Q?JfHaZ1rbszNXGRe+HlWENdIDeJLjVJXUERH0wXZitiwR0VEu8B7jmEviCBJZ?=
=?us-ascii?Q?GMQEH70hZJMhLKyG5HfVoxaDuujcNou8WW4V8jr+r6RXVaUlTuvVaDastfnc?=
=?us-ascii?Q?CbcTj/9FvSs0+ZYBiUvtUtjF19/SUZGhjKONV6ucBsTqRvVOUrVkDuaM3rs3?=
=?us-ascii?Q?sADdL7iJvEst/6F8oKpqqhaVhH9tklrCy7IuRcKeukJqRusjsSNl2iY/pqkR?=
=?us-ascii?Q?LKScKlkvnajrVR5Smq2oh0kVIYPh4QzUo+6F9vcQnGfCNm6p0eb89WjVWM8K?=
=?us-ascii?Q?r1mDQ1mzZm5rb5mJ9U44CtMU5SGVrobtXil92dqw4MHFpoP+tieMiyVmYOqg?=
=?us-ascii?Q?k51AdFE7KNVZESbYw9BnCJD8/mC5WnMpIQKTSX3+ceU1st0JnSV5qwknydiw?=
=?us-ascii?Q?lCHa9xVeE3n+tc05XN7R3GZdpih2GX/1TZ74hZflBpaCMr/uu2UsQtSz+Ge4?=
=?us-ascii?Q?fUWtU+c1J4PNAuvQwfx+0VN6YkX8ClInJVZUfwDgtYhmKlb14SHNZBBR0geA?=
=?us-ascii?Q?XDoFIwnpx6lNdE6GTqi1JL7ZMCIiyFSyrNJKi17hTG6r8QsE1R9ybb0wE36m?=
=?us-ascii?Q?I33h65TLhzeEv6+uPCiNcL6mA29y35bPf6NtmCMwDdZUHCerpofI+YlKr070?=
=?us-ascii?Q?94jWd9dLdklJo6tcOsONyTxBV36KZwetvTjW5f8BN3h5jD78r3xIiuCX0vDg?=
=?us-ascii?Q?Tz0/hYx2hXTeVzqCdt7i6AmArjt5tmKK5PtkHLIPXNVYvOws4w4y5BRJ2JpR?=
=?us-ascii?Q?Fw98BF8HyMl9gZ+V35hyd6Aq4sw76iUHSNSaP2HN7X8T17lP2zurhtQDhjbL?=
=?us-ascii?Q?GCVm0uQZccgs6UumOBD1JI=3D?=
X-Microsoft-Antispam-Message-Info: rzpl2+73F3W9PVS+tX8Jea4eGe3LHSH22kokMAPZPU8fyLGCZIqFUVISXNt+PZMmutDlGEv12E7nCShactJiX17JzMOJ75gTyHU2CyNNSk+V//FDzRYuAiNzXoA1dK5zkWr9OMixE+yUo6BlLvLIs2aldhh3HnPtK+Osh/VxrOVTl53dNZY48org4PV5dwfs
X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898;
6:ZhPlpkJMCkl5sWdLi12XdykwuUBcgrqhHt2TMnjSOA/tqm9BrTZ6CtsmWe73lEcDxhvy9dohRhzfwmrZaguqimAnDhJ5ZvUU9OrmMA/F6rlXEeRkzzSeJVZqzHUa062iu99pMb7GSKLlBgCWZjfyN4pFqqbiyqQT8SsWOsE9TyUkejatRY9ZU9MeUykUYYjIKC5TbkdQLu2jLckleHpIimniMV68gmxdwTiOb9Z+W5+K/wZc3TmcZ0yGfwxlbmYCcOEHkkuH4AEvBiuCG1zsA9U5u84MGaiJc6bikKzDfJNG4QW0HelS5GBfi+dpS23js5vjK5RFbi92BLZUNl6DsBpRQEX6bwxE7TkoZN0sE/YzClTbrQd5MVq26BbGX0mlkUTPSD8fPk/ihRa3hb4suCpmd4h4sKqD0aUt1jbVMNHSf/SeTJi7ArJHSVM0hHFSfbmHCaOOk2fyKpVwgBGLfw==;
5:yCp7J2A5+UsGx/YU1hMSOvpiAU/oe56mrihZWmfG/t+y7euyrTnGEljKMp5pXQ+PLDXOPFsBlCqlrWqqVbQlGwnABqyfWe4gkidx83hBkSgO+2Rbjrkwtned6qq9toi9gc5+8eGtzS9mhDFLh23c6cYqfJdIquYapsMGQOraMEM=;
24:SCwBDgk1INSKP5qYkhf8BVkIGUMH2nM3r9F9Kf2vkuRSxql3QnSs4moGJVJ+WdQV6Rk2x95cSYzfn1+xiUw2TSuKugvOHlnJq7KYbMUxF1M=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898;
7:Z65OCurXNlrfhAQP+BIKgAgrt/trVtDc5lMeHsOkCAHhOmudFPa2KWe4m7Vt/Ai6NpI9gogri91ZxBBhtNmWUGKFQmT6/RC6E9x/llD+o3++L9JdJf7CpFh1HeafaLUwV2WRdN5oCS/nEnEw5AR0/Hg8TDap9lprA/j/7/NAsfsEJSSDcawZokvfETZHBHl8dhrSnzqTAbu1eUNqDLVbmG6FGAau8tQLbtxl3NY18tgd59iNFRenepZt4imILVhh
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 11:50:22.9375 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a6b579c3-76fd-4552-4304-08d5d1ed03f6
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898
Subject: [dpdk-dev] [PATCH v1 12/15] examples/l2fwd: skip timer updates for
non master cores
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 11:50:26 -0000
The timer updates and checks are required only for stats printing by the
master core. This can be entirely skipped for other cores.
Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
---
v1:
* No change
examples/l2fwd/l2fwd_worker.c | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c
index 868d0c6..d6a5e90 100644
--- a/examples/l2fwd/l2fwd_worker.c
+++ b/examples/l2fwd/l2fwd_worker.c
@@ -111,6 +111,14 @@ l2fwd_periodic_drain_stats_monitor(struct lcore_queue_conf *qconf,
/* Drain buffers */
l2fwd_drain_buffers(qconf);
+ t->prev_tsc = cur_tsc;
+
+ /* Skip the timer based stats prints if not master core */
+ if (!is_master_core)
+ return;
+
+ /* On master core */
+
/* if timer is enabled */
if (timer_period > 0) {
@@ -120,16 +128,13 @@ l2fwd_periodic_drain_stats_monitor(struct lcore_queue_conf *qconf,
/* if timer has reached its timeout */
if (unlikely(t->timer_tsc >= timer_period)) {
- /* do this only on master core */
- if (is_master_core) {
- print_stats();
- /* reset the timer */
- t->timer_tsc = 0;
- }
+ /* Print stats */
+ print_stats();
+
+ /* reset the timer */
+ t->timer_tsc = 0;
}
}
-
- t->prev_tsc = cur_tsc;
}
}
--
2.7.4