From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0057.outbound.protection.outlook.com [104.47.37.57]) by dpdk.org (Postfix) with ESMTP id 3028F2B9F for ; Thu, 4 May 2017 08:10:11 +0200 (CEST) Received: from BN6PR03CA0052.namprd03.prod.outlook.com (10.173.137.14) by BL2PR03MB161.namprd03.prod.outlook.com (10.255.230.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Thu, 4 May 2017 06:10:07 +0000 Received: from BY2FFO11FD023.protection.gbl (2a01:111:f400:7c0c::186) by BN6PR03CA0052.outlook.office365.com (2603:10b6:404:4c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11 via Frontend Transport; Thu, 4 May 2017 06:10:08 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD023.mail.protection.outlook.com (10.1.15.212) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1047.9 via Frontend Transport; Thu, 4 May 2017 06:10:08 +0000 Received: from [127.0.0.1] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v4469v8H023756; Wed, 3 May 2017 23:10:05 -0700 To: Sergio Gonzalez Monroy , Pablo de Lara , References: <1493402588-163123-1-git-send-email-pablo.de.lara.guarch@intel.com> <46d732a5-3ab0-a63b-bd12-acc9372a3c57@nxp.com> <058e6ed7-9404-1333-31be-c389fe08d246@intel.com> CC: , , , From: Akhil Goyal Message-ID: <152e5bc5-26b3-2505-f5b7-842652110641@nxp.com> Date: Thu, 4 May 2017 11:39:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <058e6ed7-9404-1333-31be-c389fe08d246@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131383518085959762; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39450400003)(39410400002)(39860400002)(39850400002)(39380400002)(39400400002)(39840400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(377454003)(189002)(24454002)(199003)(9170700003)(47776003)(305945005)(65956001)(8656002)(31696002)(8676002)(65806001)(86362001)(81166006)(54906002)(7246003)(77096006)(7126002)(356003)(31686004)(23746002)(561944003)(105606002)(106466001)(189998001)(120886001)(53936002)(4326008)(76176999)(54356999)(50986999)(33646002)(6246003)(38730400002)(2906002)(50466002)(85426001)(64126003)(53546009)(36756003)(104016004)(2950100002)(498600001)(8936002)(65826007)(229853002)(5660300001)(6666003)(4001350100001)(230700001)(83506001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL2PR03MB161; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD023; 1:CI416BgeWygzPFtXbsx5UuND8GFLfdkHNUglvfgRfE6sKhDnxiSD1v/rhqR9NswQzus66O11hz5D3jPRu8C6T6XvQDD+djwPfWes585kqMsftZRBo/xSP9deBPjAGW0Fm9bZDWZwHiT2ZEFXnkUzGnJLJk+/RGdDvKnMX/gXgeQNLDHI3GhfspzTyqWGrXNaXCO+yfCVxLJi10W5PF3rXkxr/eKR9uzGpK0LtOSne89b2/BSbMEnkRcHG1WotCtGz8LFURIFsmWZRwk+eiPR4EN0AMyyzBRU0zSUUuXtACnguPCbN/8pTd9M4Kqc0EwNPWyZNKk5gi39vk07BtrmgIiVbUbEBBpjwMNYiAUKXyjHX4eDR12wQJkkzRV0y2Z596YguEXILKqZ6VUaRldyx7H8YPy9Bm8CuD4/5h2zLbCIgUv/ObO0mwzLC1QWhlEk+5l17FNVD8gWbqpUScYsGN3CVyE+HNwQbDt7iejTRcq7dxzcNlC4ew/poHr4tecTlLKGfiOW1zsmRLo/hkm6fenpcFPyJBEffvKmXGn6/tdVLgLALaQtzSZVpmdglOBi89BhB1A6+beFcr+DY3xqJuKXohncmERXggQEya9NcwifnoCf5G+hCVt14MEO4PgC1BpPpXdZxXiuyMgowScQwQ== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2714951c-ad47-4854-6ef1-08d492b4374f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:BL2PR03MB161; X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB161; 3:Dmc4klYJGYXTzu6/eSZKSuipCtL2m3io1wB58rtw9rWShVtpLkMCxL7NfLbxI7NjcJAP3IDGuk56Ha+VATk+bABYXhmnf3sw9TbTPAD4R7ATEt2BKx8sgHpKpkVlmY5d7AKYrkgELJu0x4duoow9a8OSopmZGULgXDxkFvR/e9mmquIxyek9WEP6l9aR9ghlDOEJxzwAxSElFGF+7BTLERywe5mLVGcf4Oq1HQqHpJNJ+HBT2eYnnnA6fSifjFhlMxlOGPQYncJcHL/soMrO/hUoE6b5XxN6GNdOhDYZqoA5DRxX9vyRLfH8jgbDfQCqLNRiYgWuxk9rURtWDEuC4ezsZPcVWMeBEKKMz+isYtzCGjQ07HsFcN48T4Y92fAfOuYXJnnFRt8suvzaKcVNCIrGHgns3oqKyqjlpm+G2qT3MJvqgbci5tN79m9REb8w; 25:sL++++PQp0gnACoVjrqZ+Fati8AFxZN55oFmLkUIDg6hB5+EFPrwM6EWLIlsQH0im4iW3d3wPITByxWE4ZJTAx7ddRpO4I/HWyCktD7nIj1iWG31kDmLcj/3B5O6Y2FMeT2r+++h8ES1jT7HQakWNQQmNGVcwDCg0ROzlY6TRJC2he24qeyEsTVJW6fXsc/R4nRl+Xphf4JophIoTUi48LL5AlU16N6Qr0ZS71/Gas1ekzQypWSusT4YJw/IovHnmpIsjskLYZiLYlCIATW2oTbxGZ6p6b/zDTH04h3UyGP+5yXT/DVw6hYFWEq4Xj7YnONDUURm1KE9iNEwIWpT8PYMXYJFH7uBCcC6rgO+dDAvQjVE6wsQDkxXX2APdFFMLneVbgRnRlFWEeFufYgZWqgpn7Doan6JSsfG+PZYcGoAupXdsYTK95cLgMZLS822Nv/c7fE2U6v+9WhHY+6/tA== X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB161; 31:XsGu87gN7V9sk6JB7sqipg4vDYzdd5EQRhFVxJ57SaKRQ7JqN6pUoMTHJb23szsdisG3XwCPtDJlg3qN6HDugm/B3j3s2PRXwvxlFJEOnXT5wH+Xp+Q4htl59X/+dQ4/9sqdVIc4J4JP9v/bdf7f5DuU6Ix+tK4zkwEJse7Oe5YSyyEq+oxKBCmO+wlDbrPtSyYP8raVsfFJngz9frf0BBI76Ynnb3xJEbinx8zIHaGC7/5txEVf/80R1yDhxXIzd6YsqNCKn1Mk3sb8HAk/5A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13015025)(13017025)(8121501046)(5005006)(13018025)(13023025)(13024025)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123563025)(20161123561025)(20161123556025)(20161123565025)(20161123559100)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153); SRVR:BL2PR03MB161; BCL:0; PCL:0; RULEID:(400006); SRVR:BL2PR03MB161; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BL2PR03MB161; 4:SdMX0DG0GCGS98wDe2tURTUJskxE5JbsQWOO9Yn?= =?Windows-1252?Q?FZCs8Lcfzs45PevXl1w8MfzRGVOo1VQtVapVX7kDtOgHvfEVNBYnQCNj?= =?Windows-1252?Q?kvpFzolNSwmcrZm1yGN31MRsZbjtaUZAM0g6O4PyOH7hjS75nCtUHoYQ?= =?Windows-1252?Q?hiYwZMzhKQDF+4UcRFeMq1+7IyuFa30vdixW7dC5TUDmNfhR9fg4Zgo/?= =?Windows-1252?Q?Hbh+ITyQFrV2dgZCdqTSUCkgWKSLrWYjUiKwJpuf4p8woSrBSTnrqehM?= =?Windows-1252?Q?dkxvhczmZj6Cb+W3+lDzWMvpt58H6s4vwOgtNtEBr3e4iT9lR8drxueK?= =?Windows-1252?Q?HNPNE16WHPZgeJk1NhkA9kAO05jaBiC1qCYqpGUar6xbWuNuOLj2DyKr?= =?Windows-1252?Q?2TV/HSeac7l0ovDD1J4qa0NaUnFeG+yn//dcqfoggfTl7esWuVfRkhm8?= =?Windows-1252?Q?TXxVBKeV5RV69kjD0inSfmGjTX3H5f3zul7ISAl7Cc06TQZMGlLHv1bH?= =?Windows-1252?Q?B/tn5GlRxBcH7mVumcUoYDqpxQc/7GZwhQESKd6V78BMDmIdmkrnZuoT?= =?Windows-1252?Q?XAlB27mxLA9BYD5lfnLY1INS8+8fiNcDdDltYbYJQhquFD+ta0W9CD4r?= =?Windows-1252?Q?tNRiKHqJMl3dlNAzBmlkvRmImvQ5xmLSImINwLi04fr82ljQmtOL5otx?= =?Windows-1252?Q?gHtMOAjlJ+Qft2D2bc7Le31B76lAog/uwFTIt0jbo2TfGIhqRME0/hqV?= =?Windows-1252?Q?LzkGQXYM3EFiW5L+6D6Fgkm6vaZssjo0lHi8IqCrmislUjXI4YAwrxmx?= =?Windows-1252?Q?o05tI7mlDBh1nyZUnoKNCDSn/XEGeMBuyvVBo1rXfNupSLMqalLpt/99?= =?Windows-1252?Q?hEkKqwZBiDljz5ZIQ8UjQpvo/JXgeG1pb3ftSEUHxOhocacTqbTzF3nK?= =?Windows-1252?Q?cY/GvSRteJwgXz0wdrCDAJGjE2FZUzJ5aHBKm9yyw+I6xtOwQe8JCNLb?= =?Windows-1252?Q?+jrMoLe2U6XAPROqbuNomqnvmY6OufE3n4fIRbr3VzkLLMA=3D=3D?= X-Forefront-PRVS: 02973C87BC X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BL2PR03MB161; 23:nX3jyBKfrHpmp/cGBV5dbOOGl7wi2FPWQoesOh?= =?Windows-1252?Q?cAchGHoIncqegFThbADB4dycYVbfdgZxOHMbWAA1k0qzXHonmN4sVwUl?= =?Windows-1252?Q?2b8Pe2p0fGOL/GD/rYxhOhNzLTWAUbgsBrfKb1UaHG8R+cloKjBGAmlo?= =?Windows-1252?Q?KUh1xpxLoaTZ0ILLps7OlLEay9PWRTNyysacvVC+yDNdZ3C4Gy2Ppaiu?= =?Windows-1252?Q?Avw1Hg5YDF9hpNTRVelHD/3AxLN5+R6+h2b9XJcZhJRG1q0AByMzeE6A?= =?Windows-1252?Q?hM3q9e7kjd3kYZ4558MVRjco8DVjVl6GiJaR8FNKl5QcQN46u63w8oWg?= =?Windows-1252?Q?Fxdd17W2wkrCPtDSwG9Vgl3PJzmiqVy9sAqRg7pKJvCUeelHuMlYBoSf?= =?Windows-1252?Q?QFwRDtW8suAYn2Lm608MEtFIAELEUxPHMFvkEkDNgqyL5fxsU3ufDc5Z?= =?Windows-1252?Q?mCmzKp3sxx7kvm6LtbCIkcP9wDCAeh5/HQfKTh2JYR5x38um7w0Ojeqw?= =?Windows-1252?Q?c4n5u9DiZEIiqFEFd25KykQhAJTRHcpy1NFgi2g9/r8VW4z+435Si1AS?= =?Windows-1252?Q?FsHqN+Epe9E7jYebhFXsAlktv5lHbW+layA98p1rmTWhf7y7BcpYt0qZ?= =?Windows-1252?Q?IErPE8sPIga3HW3P2OY+mS38X/muIn0JjFj/FH1AfFMPO8RJQSQcl9jG?= =?Windows-1252?Q?PQdNKsd5XIkuAfq4kQf6iXDujgy8uqZBOjEYz49hdMKJJVqnTPBcBcE1?= =?Windows-1252?Q?HLk83DCTkzOCzXMj1ZLgSruxu2QPa8G3Stuyx4T65kwE2FwWL6xzExwi?= =?Windows-1252?Q?mHFWWwpOQlXBTT0qy5RG9Nw+6VlMZ5bsNt+pVNGYsejjIRuaGVeSLmPL?= =?Windows-1252?Q?+ZTOjaGX8EATxfAopfH/NYH3BCm0K4K2BU0c+0XkpU1dU3k4RtHNHkYE?= =?Windows-1252?Q?Z7fudAnCVejTAXUDlu9LGnFKUdZyT1uOUHquoaJR1UTdSrkFWi+/8Ktg?= =?Windows-1252?Q?yvreE/YAVtoEuxiEry61Pln+7od25dY9AI33sWzvkt/uVQQFv2aybun0?= =?Windows-1252?Q?OZdvaAMRKsBofP72mEYJ5B2JkCGaZmrBgW0mShlqrVD1dBGvA++HH/7b?= =?Windows-1252?Q?7tBgUiSm9/fe1zL4vAzBqLR0SSi+NL/HIfbM1VoLWsmtuXo7PomZ1oXi?= =?Windows-1252?Q?Wo3eLOodX4pYZG8/yIiTcNjFPjrH7h7gHunLDCYfE559DzQFYz20Pk2h?= =?Windows-1252?Q?60KF50WCsAPpGPZ1SyR0jCT3bZtkb/TiZqmyT/DZMXm495TW96ffZ68E?= =?Windows-1252?Q?z7Abc+KD2mpEFWqLYW3q6+HsgJv+Pe3vDxXzBwVvJ5I9f0G+mtnNYR0a?= =?Windows-1252?Q?Cip2wAGca2LmV7VEOzph6WfTmXCGpfvaZyU6z2JMBZJ8HsRBn+mZglND?= =?Windows-1252?Q?0OnoDyUbVM3YTVQlp/v/mysqPfKs/TdUGM7a9XjQUOA1omoWVj9ee3lx?= =?Windows-1252?Q?/xiiOUk4hOXxmp8SB9ENzPtgmybc8MX42x20HIXtqKIJ2tlqTGzoaf3V?= =?Windows-1252?Q?VIxgMmaiTMK6SbC8zdJZ2JKQWAIGhDoKrBJgtZ8M/vUqMR3Ix+VqFrTl?= =?Windows-1252?Q?Z89JhFVSbkh+cNK13sl8lGRIAQ47322jT2K6vCEeItBs6RTrCwkeGhhE?= =?Windows-1252?Q?npeS1uwWT4DPTN86FanRluYOJ/RNU=3D?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB161; 6:Qeb/78nGbj5xJgOgGZWQ5VNuVH0M0IoZpMeufNgOKWlOfqs5HsxQPIn2rLD9Y69nnLBEJYfGLclDFci5L4u6ksXQVDsxeovKoqRAv0GS2+8hX7mZip/r5tVlGlEmKXA0x5EkEmn532FguvaXrjLaYpVIzjoyA/EuieYNqO5b6ewpczesW9BYugdOJothuFcUZ6Lw42S2Je0M4zTdRa1UnfImLotqigSh7O2cZ1S5vCUOhzwX3RSsYQTPV5Kz7gmtzCbD1RQ5LO6UXqC9P8t1Toub+lDhOXVxxWW+MceyBY9r2Mr4kArOO9RKOvAxH7bNBJ21FnJXbag9I4mEYtrcNmhE/wYlnDTbuFMj4/WLSA4f0vHH8vFnAfU49c0hXfvgZ1FirJmBsCVnVGbOiAP4jokpFPbTpATW86NS/M0rheNFJysfEcfeDXypLQXlYwnrvLTUP31tbpHaVe75v7V+mh6+E++ZPxKQJdcQlI+DVJXOUUZkZNxaYSoGGCmPQZwbP39mR3bAJI1K8wJoCxIxPQ==; 5:MxtedKw+2Mh0SG3RpbQ9a+JriKGx49N5wiQ8swxA1Yce+jaaGR1SeEfJSNzVG/Bn6SkB+ECFj2N5yFoJOYCvmj5WrTo1GvBntsx3VQD4U6lnQDQRWW+z+MOgCMEbKHVShH18m0qYBkz9rAl+jTvU/jRY+4lVXOqzcjkAqFhjnFaumgClwDNBdtmmvZJZopId; 24:HxqiT/ig1sVUCHpZ10pxeCo7w/ExeRWZs6u6yB64WWz2JA/GcZmshKSaoi53ouxRr6c6xwk7kUL6Xs1YvYSwUOWXfaH/SGTmnpb3Fyp9nxg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB161; 7:KVgHeIxWwj/f3aitIEAsYNXCwUTa7t8PsvVDoookJf6rKikl6i9+bfJlNDCtPoN30viUJ+STCre5cOKagrkfksfEnbgl8yrQMKRR6fI6cr9d/CPJLxo9dLBytaz5CrnNohrNGgcpthblGv5x+Uv4UojzzRQkkPZT2i/aW8gSsJf5H5mB2Vzl/NfBg4TQVBq8Rec2S+Z8xjiZYRa42PNJRP5uYYByDxBSKBf/tFox22zTl5uXfd/CaCgrE1LrLCYgK+Slo/OESdhUTlrVxxSIccz8T1GSRAqvvNQHHYVPYqYl54GI1YTIJJm5YRaNWKWa1L0+shz6y+Z4aY3tRLhLAQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2017 06:10:08.2995 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB161 Subject: Re: [dpdk-dev] [PATCH] [RFC] cryptodev: crypto operation restructuring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 May 2017 06:10:12 -0000 Hi Sergio, On 5/3/2017 7:48 PM, Sergio Gonzalez Monroy wrote: > On 03/05/2017 12:01, Akhil Goyal wrote: >> Hi Pablo, >> >> On 4/28/2017 11:33 PM, Pablo de Lara wrote: >>> This is a proposal to correct and improve the current crypto >>> operation (rte_crypto_op) >>> and symmetric crypto operation (rte_crypto_sym_op) structures, shrinking >>> their sizes to fit both structures into two 64-byte cache lines as >>> one of the goals. >>> >>> The following changes are proposed: >>> >>> In rte_crypto_op: >>> >>> - Move session type (with session/sessionless) from symmetric op to >>> crypto op, >>> as this could be used for other types >>> >>> - Combine operation type, operation status and session type into a >>> 64-bit flag (each one taking 1 byte), >>> instead of having enums taking 4 bytes each >> [Akhil] wouldn't this be a problem? Bit fields create endianness >> issues. Can we have uint8_t for each of the field. > > Sure, as it is proposed it would be the same as having 3 uint8_t fields. > The idea was to possibly compact those fields (ie. we do not need 8 bits > for sess_type) to make better use of the bits and add asym fields there > if needed. > > I don't think bitfields would be a problem in this case. Agree, we > should not use both bitmask and bitfields, but we would use just bitfields. > Can you elaborate on the issue you see? > > Regards, > Sergio > The problem will come when we run on systems with different endianness. The bit field positioning will be different for LE and BE. It would be like in LE uint64_t type:8; uint64_t status:8; uint64_t sess_type:8; uint64_t reserved:40; and on BE it would be uint64_t reserved:40; uint64_t sess_type:8; uint64_t status:8; uint64_t type:8; So it would be better to use uint8_t for each of the field. >>> >>> - Remove opaque data from crypto operation, as private data can be >>> allocated >>> just after the symmetric (or other type) crypto operation >>> >>> - Modify symmetric operation pointer to zero-array, as the symmetric >>> op should be always after the crypto operation >>> >>> In rte_crypto_sym_xform: >>> >>> - Remove AAD length from sym_xform (will be taken from operation only) >>> >>> - Add IV length in sym_xform, so this length will be fixed for all >>> the operations in a session >> A much needed change. This would remove hard codings for iv length >> while configuring sessions. >>> >>> In rte_crypto_sym_op: >>> >>> - Separate IV from cipher structure in symmetric crypto operation, as >>> it is also used in authentication, for some algorithms >>> >>> - Remove IV pointer and length from sym crypto op, and leave just the >>> offset (from the beginning of the crypto operation), >>> as the IV can reside after the crypto operation >>> >>> - Create union with authentication data and AAD, as these two values >>> cannot be used at the same time >> [Akhil] Does this mean, in case of AEAD, additional authentication >> data and auth data are contiguous as we do not have explicit auth data >> offset here. >>> >>> - Remove digest length from sym crypto op, so this length will be >>> fixed for all the operations in a session >>> >>> - Add zero-array at the end of sym crypto op to be used to get extra >>> allocated memory (IV + other user data) >>> >>> Previous rte_crypto_op (40 bytes) and rte_crypto_sym_op (114 bytes) >>> structures: >>> >>> struct rte_crypto_op { >>> enum rte_crypto_op_type type; >>> >>> enum rte_crypto_op_status status; >>> >>> struct rte_mempool *mempool; >>> >>> phys_addr_t phys_addr; >>> >>> void *opaque_data; >>> >>> union { >>> struct rte_crypto_sym_op *sym; >>> }; >>> } __rte_cache_aligned; >>> >>> struct rte_crypto_sym_op { >>> struct rte_mbuf *m_src; >>> struct rte_mbuf *m_dst; >>> >>> enum rte_crypto_sym_op_sess_type sess_type; >>> >>> RTE_STD_C11 >>> union { >>> struct rte_cryptodev_sym_session *session; >>> struct rte_crypto_sym_xform *xform; >>> }; >>> >>> struct { >>> struct { >>> uint32_t offset; >>> uint32_t length; >>> } data; >>> >>> struct { >>> uint8_t *data; >>> phys_addr_t phys_addr; >>> uint16_t length; >>> } iv; >>> } cipher; >>> >>> struct { >>> struct { >>> uint32_t offset; >>> uint32_t length; >>> } data; >>> struct { >>> uint8_t *data; >>> phys_addr_t phys_addr; >>> uint16_t length; >>> } digest; /**< Digest parameters */ >>> >>> struct { >>> uint8_t *data; >>> phys_addr_t phys_addr; >>> uint16_t length; >>> } aad; >>> >>> } auth; >>> } __rte_cache_aligned; >>> >>> New rte_crypto_op (24 bytes) and rte_crypto_sym_op (72 bytes) >>> structures: >>> >>> struct rte_crypto_op { >>> uint64_t type: 8; >>> uint64_t status: 8; >>> uint64_t sess_type: 8; >>> >>> struct rte_mempool *mempool; >>> >>> phys_addr_t phys_addr; >>> >>> RTE_STD_C11 >>> union { >>> struct rte_crypto_sym_op sym[0]; >>> }; >>> } __rte_cache_aligned; >>> >>> struct rte_crypto_sym_op { >>> struct rte_mbuf *m_src; >>> struct rte_mbuf *m_dst; >>> >>> RTE_STD_C11 >>> union { >>> struct rte_cryptodev_sym_session *session; >>> struct rte_crypto_sym_xform *xform; >>> }; >>> >>> struct { >>> uint8_t offset; >>> } iv; >>> >>> struct { >>> union { >>> struct { >>> uint32_t offset; >>> uint32_t length; >>> } data; >>> struct { >>> uint32_t length; >>> uint8_t *data; >>> phys_addr_t phys_addr; >>> } aad; >>> }; >>> >>> struct { >>> uint8_t *data; >>> phys_addr_t phys_addr; >>> } digest; >>> >>> } auth; >>> struct { >>> struct { >>> uint32_t offset; >>> uint32_t length; >>> } data; >>> >>> } cipher; >>> >>> __extension__ char _private[0]; >>> }; >>> >>> Signed-off-by: Pablo de Lara >>> --- >> >> Comments inline. >> >> Regards, >> Akhil >> >> > >