DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
To: dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, reshma.pattan@intel.com,
	Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
Subject: [dpdk-dev] [PATCH v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
Date: Mon,  2 Jul 2018 13:30:56 +0100	[thread overview]
Message-ID: <1530534656-12125-1-git-send-email-jananeex.m.parthasarathy@intel.com> (raw)
In-Reply-To: <1528785534-23425-1-git-send-email-jananeex.m.parthasarathy@intel.com>

From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com> 

For librte_cryptodev dynamic logging, conditional compilation of
debug logs would not be required anymore.

Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com> 
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Pablo de Lara Guarch <pablo.de.lara.guarch@intel.com>
---
v2: unused macro removed from config/common_base and rte_dev.h
---

 config/common_base                      | 1 -
 lib/librte_cryptodev/rte_cryptodev.h    | 8 --------
 lib/librte_eal/common/include/rte_dev.h | 1 -
 3 files changed, 10 deletions(-)

diff --git a/config/common_base b/config/common_base
index 6541ad5b2..84317a9bd 100644
--- a/config/common_base
+++ b/config/common_base
@@ -460,7 +460,6 @@ CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW=n
 # Compile generic crypto device library
 #
 CONFIG_RTE_LIBRTE_CRYPTODEV=y
-CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
 CONFIG_RTE_CRYPTO_MAX_DEVS=64
 
 #
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index b7a4cf0a2..ccc0f73fd 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -38,7 +38,6 @@ extern const char **rte_cyptodev_names;
 		RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
 			RTE_FMT_TAIL(__VA_ARGS__,)))
 
-#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG
 #define CDEV_LOG_DEBUG(...) \
 	RTE_LOG(DEBUG, CRYPTODEV, \
 		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
@@ -49,13 +48,6 @@ extern const char **rte_cyptodev_names;
 		RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
 			dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
 
-#else
-#define CDEV_LOG_DEBUG(...) (void)0
-#define CDEV_PMD_TRACE(...) (void)0
-#endif
-
-
-
 /**
  * A macro that points to an offset from the start
  * of the crypto operation structure (rte_crypto_op)
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index 3879ff3ca..d4b43512c 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -70,7 +70,6 @@ rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)
  * RTE_*_RET() macros defined below is compiled in debug mode.
  */
 #if defined(RTE_LIBRTE_ETHDEV_DEBUG) || \
-	defined(RTE_LIBRTE_CRYPTODEV_DEBUG) || \
 	defined(RTE_LIBRTE_EVENTDEV_DEBUG)
 #define RTE_PMD_DEBUG_TRACE(...) \
 	rte_pmd_debug_trace(__func__, __VA_ARGS__)
-- 
2.16.3

  parent reply	other threads:[~2018-07-02 12:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  6:38 [dpdk-dev] [PATCH] lib/cryptodev: " Jananee Parthasarathy
2018-06-21 14:11 ` Akhil Goyal
2018-06-21 14:12   ` Akhil Goyal
2018-06-27 16:36     ` De Lara Guarch, Pablo
2018-07-02 12:30 ` Jananee Parthasarathy [this message]
2018-07-02 15:51   ` [dpdk-dev] [PATCH v2] cryptodev: " De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530534656-12125-1-git-send-email-jananeex.m.parthasarathy@intel.com \
    --to=jananeex.m.parthasarathy@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).