From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, anatoly.burakov@intel.com, maxime.coquelin@redhat.com
Subject: [dpdk-dev] [PATCH v2 5/6] net/nfp: check hugepages IOVAs based on DMA mask
Date: Tue, 3 Jul 2018 13:09:48 +0100 [thread overview]
Message-ID: <1530619789-33337-6-git-send-email-alejandro.lucero@netronome.com> (raw)
In-Reply-To: <1530619789-33337-1-git-send-email-alejandro.lucero@netronome.com>
NFP devices can not handle DMA addresses requiring more than
40 bits. This patch uses rte_dev_check_dma_mask with 40 bits
and avoids device initialization if memory out of NFP range.
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index d9cd047..5976f37 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2649,6 +2649,14 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq)
pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
+ /* NFP can not handle DMA addresses requiring more than 40 bits */
+ if (rte_eth_dev_check_dma_mask(40) < 0) {
+ RTE_LOG(INFO, PMD, "device %s can not be used:",
+ pci_dev->device.name);
+ RTE_LOG(INFO, PMD, "\trestricted dma mask to 40 bits!\n");
+ return -ENODEV;
+ };
+
if ((pci_dev->id.device_id == PCI_DEVICE_ID_NFP4000_PF_NIC) ||
(pci_dev->id.device_id == PCI_DEVICE_ID_NFP6000_PF_NIC)) {
port = get_pf_port_number(eth_dev->data->name);
--
1.9.1
next prev parent reply other threads:[~2018-07-03 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 12:09 [dpdk-dev] [PATCH v2 0/6] use IOVAs check " Alejandro Lucero
2018-07-03 12:09 ` [dpdk-dev] [PATCH v2 1/6] mem: add function for checking memsegs IOVAs addresses Alejandro Lucero
2018-07-03 12:37 ` Burakov, Anatoly
2018-07-03 12:09 ` [dpdk-dev] [PATCH v2 2/6] ethdev: add function for checking IOVAs by a device Alejandro Lucero
2018-07-03 12:09 ` [dpdk-dev] [PATCH v2 3/6] bus/pci: use IOVAs check when setting IOVA mode Alejandro Lucero
2018-07-03 12:09 ` [dpdk-dev] [PATCH v2 4/6] mem: use address hint for mapping hugepages Alejandro Lucero
2018-07-03 12:37 ` Burakov, Anatoly
2018-07-03 12:09 ` Alejandro Lucero [this message]
2018-07-03 12:09 ` [dpdk-dev] [PATCH v2 6/6] net/nfp: support IOVA VA mode Alejandro Lucero
2018-07-03 12:33 ` [dpdk-dev] [PATCH v2 0/6] use IOVAs check based on DMA mask Burakov, Anatoly
2018-10-05 12:06 Alejandro Lucero
2018-10-05 12:06 ` [dpdk-dev] [PATCH v2 5/6] net/nfp: check hugepages IOVAs " Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530619789-33337-6-git-send-email-alejandro.lucero@netronome.com \
--to=alejandro.lucero@netronome.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).