From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] testpmd: force user to stop forwarding when changing port/core list
Date: Sun, 15 Feb 2015 16:57:37 +0100 [thread overview]
Message-ID: <1530680.DEeoNRuZus@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A806FC6@SHSMSX104.ccr.corp.intel.com>
> > Testpmd has the capability of changing the forwarding cores and ports in
> > runtime.
> > If these are changed when forwarding, two issues may be encountered:
> >
> > - If "show config fwd" is used, changes made in the core list are applied.
> > Therefore, trying to stop forwarding may hang testpmd,
> > since it could be waiting for cores to stop that are not actually running
> > anything
> >
> > - If the port list is changed, when stopping forwarding,
> > it may miss the stats of some of the ports that were actually being used.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-02-15 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 14:53 Pablo de Lara
2015-02-11 6:56 ` Zhang, Helin
2015-02-15 15:57 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530680.DEeoNRuZus@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).