DPDK patches and discussions
 help / color / mirror / Atom feed
From: Xiaoyun Li <xiaoyun.li@intel.com>
To: wenzhuo.lu@intel.com, jingjing.wu@intel.com
Cc: dev@dpdk.org, Xiaoyun Li <xiaoyun.li@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] app/testpmd: fix dcb config failure
Date: Tue, 24 Jul 2018 19:32:34 +0800	[thread overview]
Message-ID: <1532431954-123708-1-git-send-email-xiaoyun.li@intel.com> (raw)

After adding RSS hash offload check, default rss_hf will fail on devices
that do not support all bits. This will lead to dcb config failure. The
patch fixes this issue by taking rss_hf as a suggested value and only
setting bits that the device supports based on rte_eth_dev_get_info.

Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class")
Cc: stable@dpdk.org

Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index f504ca3..d221469 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2575,6 +2575,9 @@ init_port_dcb_config(portid_t pid,
 	if (retval < 0)
 		return retval;
 	port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
+	rte_eth_dev_info_get(pid, &rte_port->dev_info);
+	port_conf.rx_adv_conf.rss_conf.rss_hf &=
+			rte_port->dev_info.flow_type_rss_offloads;
 
 	/* re-configure the device . */
 	rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
-- 
2.7.4

             reply	other threads:[~2018-07-24 11:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 11:32 Xiaoyun Li [this message]
2018-07-24 16:16 ` Iremonger, Bernard
2018-07-26 17:18   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-07-31 14:43 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev
2018-08-01  8:46   ` Iremonger, Bernard
2018-08-01 14:32     ` Thomas Monjalon
2018-08-02  2:31   ` Zhao, MeijuanX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532431954-123708-1-git-send-email-xiaoyun.li@intel.com \
    --to=xiaoyun.li@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).