From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 029E1A48B
 for <dev@dpdk.org>; Mon, 22 Jan 2018 03:06:13 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 86C8B2098B;
 Sun, 21 Jan 2018 21:06:13 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Sun, 21 Jan 2018 21:06:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=lPlYkvC9hgko5rE3pnc/OvXo3O
 syUjQZOLsQbcJit4U=; b=sna+k0SyB+nbVhgF88tF/AJ0b5t4SDx8BOqFNK94AD
 pPWLiohHdVAoeQpCPwz0zsKbBw8Dxo2FO28qK47oF35wCVn17VrCpPgYeFHNqS9i
 WMTMJVpmxgrVEXvtF+zZVZZfydVGnym5ka5ebEj7zlwTEmo15LLudkJJ9iW3MuL9
 c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=lPlYkv
 C9hgko5rE3pnc/OvXo3OsyUjQZOLsQbcJit4U=; b=bwlzbe1tfhY2Z1OXlJx4Mn
 vrHNFsLoQXANKYFYHxUPxFQaOzMOo/6mU4FJKWjXrZ1ahAvPXnBIHb7k6oUoKSF5
 EC6STHk8ICVmeeZVox0j4VsLzGSmY+wiTbUyMuA9bQQQ6j7a2jvZ3swMVifPzvri
 f/HAfcI3hTdq+ZFXpVpYpHVKwYQrtGj5tQ/oGh7tA0i3b0nCyYPU7mTzTLkWgOL2
 tDJSLs90DV1qj41/Z0s03GGW49jvUIR2W74tePWWv7QsStfzVWeS8n47QLtPQ4LI
 LNwXaAh6RhSKsUoXlp/KxYSL7NnoSwIl/NV6IMCXAAXuwYTJ0JyiAThtoLcb96uw
 ==
X-ME-Sender: <xms:FUdlWrfrY6syg40TLK74Rnh4XEsD9UPMjItRLXFbThQPF8ZZzdv-aA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1B20A7E125;
 Sun, 21 Jan 2018 21:06:13 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 22 Jan 2018 03:05:36 +0100
Message-ID: <1534298.C48F8mzJuD@xps>
In-Reply-To: <20180122015429.GC5415@neilslaptop.think-freely.org>
References: <20180115190545.25687-1-nhorman@tuxdriver.com>
 <10549424.KHioEKbQpN@xps>
 <20180122015429.GC5415@neilslaptop.think-freely.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] checkpatches.sh: Add checks for ABI
	symbol addition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2018 02:06:14 -0000

22/01/2018 02:54, Neil Horman:
> On Sun, Jan 21, 2018 at 09:29:18PM +0100, Thomas Monjalon wrote:
> > >  	$verbose || printf '\n### %s\n\n' "$3"
> > >  	printf '%s\n' "$report" | sed -n '1,/^total:.*lines checked$/p'
> > > +
> > > +	echo
> > > +	echo "Checking API additions/removals:"
> > 
> > You should respect $verbose before printing such header.
> > 
> I can add a quiet/verbose mode option, but I didn't think it was needed here
> since its being run automatically from within checkpatches.

I mean there is a verbose option already.
So you just have to take it into account when printing.
Thanks