From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples: fix typdef in performance thread app
Date: Mon, 14 May 2018 12:25:58 +0200 [thread overview]
Message-ID: <1534703.MBAexOQAkQ@xps> (raw)
In-Reply-To: <20180514025315.87149-1-david.hunt@intel.com>
14/05/2018 04:53, David Hunt:
> The function pthread_create() expects void *(*func) (void *)
> for function pointer, however, lthread_func_t was defined as
> void (*func) (void *), so now gcc 8.1 warns that the cast is
> incorrect, causing a compilation failure. This patch changes
> the declaration of lthread_func_t from returning a void to
> returning a void*, and then changes the sample app in the
> relevant places that are affected by the typedef change.
>
> Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem")
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Title: examples/performance-thread: fix return type of threads
Applied, thanks
prev parent reply other threads:[~2018-05-14 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 5:31 [dpdk-dev] [PATCH] " David Hunt
2018-05-11 15:47 ` De Lara Guarch, Pablo
2018-05-13 21:37 ` Thomas Monjalon
2018-05-14 10:01 ` Hunt, David
2018-05-14 2:53 ` [dpdk-dev] [PATCH v2] " David Hunt
2018-05-14 10:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534703.MBAexOQAkQ@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).