From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, ferruh.yigit@intel.com
Subject: [dpdk-dev] support MAC changes when no live changes allowed
Date: Fri, 24 Aug 2018 12:15:56 +0100 [thread overview]
Message-ID: <1535109359-48584-1-git-send-email-alejandro.lucero@netronome.com> (raw)
This is a patched to fix a functionality coming with the first public
release: changing/setting MAC address.
The original patch assumes all NICs can safely change or set the MAC
in any case. However, this is not always true. NFP depends on the firmware
capabilities and this is not always supported. There are other NICs with
this same limitation, although, as far as I know, not in DPDK. Linux kernel
has a IFF_LIVE_ADDR_CHANGE flag and two NICs are checking this flag for
allowing or not live MAC changes.
The flag proposed in this patch is just the opposite: advertise if live
change not supported and assuming it is supported other way.
Although most NICs support rte_eth_dev_default_mac_addr_set and this
function returns and error when live change is not supported, note that
this function is invoked during port start but the value returned is not
checked. It is likely this is good enough for most of the cases, but
bonding is relying on this start then mac set/change, and a PMD ports is
not properly configured for being used as an slave port in some bonding
modes.
v2:
- add RTE_ETH_DEV_NOLIVE_MAC_ADDR comment in rte_eth_dev_default_mac_addr_set doc
- add rte_eth_dev_start change in release API changes
next reply other threads:[~2018-08-24 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 11:15 Alejandro Lucero [this message]
2018-08-24 11:15 ` [dpdk-dev] [PATCH v2 1/3] ethdev: fix MAC changes when live change not supported Alejandro Lucero
2018-08-24 12:27 ` Ferruh Yigit
2018-08-24 12:45 ` Alejandro Lucero
2018-08-24 12:29 ` Ferruh Yigit
2018-08-24 11:15 ` [dpdk-dev] [PATCH v2 2/3] net/nfp: fix live MAC changes " Alejandro Lucero
2018-08-24 11:15 ` [dpdk-dev] [PATCH v2 3/3] doc: comment rte_eth_dev_start change Alejandro Lucero
2018-08-24 12:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535109359-48584-1-git-send-email-alejandro.lucero@netronome.com \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).