From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6603C3772; Wed, 29 Aug 2018 09:48:43 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 6B2A7B00064; Wed, 29 Aug 2018 07:48:42 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 29 Aug 2018 00:48:39 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Wed, 29 Aug 2018 00:48:39 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w7T7mbSj029214; Wed, 29 Aug 2018 08:48:37 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 7B5EF1626D1; Wed, 29 Aug 2018 08:48:36 +0100 (BST) From: Andrew Rybchenko To: Declan Doherty , Chas Williams CC: , Igor Romanov , Date: Wed, 29 Aug 2018 08:48:30 +0100 Message-ID: <1535528910-2285-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24060.005 X-TM-AS-Result: No-4.581400-4.000000-10 X-TMASE-MatchedRID: YzvagDDfcYhM4VjZ76ar2Ef49ONH0RaSzmsVTBhahkpF+YXPIqAdvrbk HKUjdwwkRwuM2c0AhQjQXnWb4yS/fQZW9dxqQRhrKaMQ6tw7oDJMkOX0UoduubvmLKLbx4LEr9Y /9i+8T9bftLFtxOSbQ4Ay6p60ZV62fJ5/bZ6npdiujVRFkkVsm3pOTlC6MTgEwDyEnJw33sXBBa 700GbbVc+zTSVTTs9UQAlIE6Y0xxEVGdaeEzY4fUfzmgmX4HNg+TqtGq3mgR1xUCJFxmdxl/Dsn HBTQS9kyoRE4tv/7I7j/Qm+fSvAAma0vgPD7M1vmFd/HOChTo8= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.581400-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24060.005 X-MDID: 1535528923-P6Pux3SB2nq2 Subject: [dpdk-dev] [PATCH] net/bonding: use evenly distributed default RSS RETA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 07:48:43 -0000 From: Igor Romanov Default Redirection Table that is set in bonding driver is distributed evenly over all Rx queues only within every RETA group (the first RETA entries in every group are always start with zero). But in the most drivers, default RETA is distributed over all Rx queues without sequence resets in the beginning of a new group, which implies more balanced per-core load. Change the default RETA to be evenly distributed over all Rx queues considering the whole table. Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index b84f32263..0f5ab09e3 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -3293,7 +3293,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev) for (i = 0; i < RTE_DIM(internals->reta_conf); i++) { internals->reta_conf[i].mask = ~0LL; for (j = 0; j < RTE_RETA_GROUP_SIZE; j++) - internals->reta_conf[i].reta[j] = j % dev->data->nb_rx_queues; + internals->reta_conf[i].reta[j] = + (i * RTE_RETA_GROUP_SIZE + j) % + dev->data->nb_rx_queues; } } -- 2.17.1