From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 54FA52BF7 for ; Fri, 31 Aug 2018 12:35:29 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id t25-v6so4848047wmi.3 for ; Fri, 31 Aug 2018 03:35:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=28HotwHCdbAnrr6G+SdclRoGQGCpdWN9hiOot2anqaQ=; b=MzofKqfEn3O18uSynvh40EUw/Pc8rykWxZ1GtEL5hAdSvamJ8Sj7uZtvqfoRalAe0z /yl1aHUCK2TVP42gDqKs3b3+BnChmnjBZX6OC4NGPgM4mg1tMF9DD1d5aQHcOAzwTQx+ s0Tbxkuu0QVz8RNYNyhf3KZu31TdcA9DgcyA4o/2Ic8INSOc1l2SQhM1O5O/b4vdjr+o hCGuwfdQUWpDadpZ+806XIhfoTyDoz4779Pp0l50jzmc/VjoPw7mHc3uLVF3IxdRPf9t wlconfmveWL75Ng8WDTJPzSmojrdE9ASJHPoR1QUQcY2vEipE7LABAzhH/BERtvN6n9L x4CA== X-Gm-Message-State: APzg51Cdq9lf/Evh6VavY6t+JSIrKERewcIBZzp42yI/77g6Ysk3iXFw uCmpPEq6UImr0XF2yGR0ygxfMp/S X-Google-Smtp-Source: ANB0VdamJwj2aWdjy/I6d9cvRRkKeoIZFqgwrByWViDtV1udjNLLSpapnHdHEHJUCJaokq3WhoOjWA== X-Received: by 2002:a1c:e157:: with SMTP id y84-v6mr4614631wmg.8.1535711729042; Fri, 31 Aug 2018 03:35:29 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 66-v6sm6831930wmw.34.2018.08.31.03.35.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 03:35:28 -0700 (PDT) Message-ID: <1535711727.11823.24.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Fri, 31 Aug 2018 11:35:27 +0100 In-Reply-To: <20180831101733.GB19592@bricha3-MOBL.ger.corp.intel.com> References: <20180831092029.4887-1-bluca@debian.org> <20180831092029.4887-2-bluca@debian.org> <20180831101733.GB19592@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 10:35:29 -0000 On Fri, 2018-08-31 at 11:17 +0100, Bruce Richardson wrote: > On Fri, Aug 31, 2018 at 10:20:27AM +0100, Luca Boccassi wrote: > > This PMD is built with -Wno-format, which means GCC errors out if > > -Wformat-security is used. > >=20 > > Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share > > code") > >=20 > > Signed-off-by: Luca Boccassi > > --- > > =C2=A0drivers/raw/ifpga_rawdev/base/meson.build | 2 +- > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/raw/ifpga_rawdev/base/meson.build > > b/drivers/raw/ifpga_rawdev/base/meson.build > > index cb6553521d..aadfc19084 100644 > > --- a/drivers/raw/ifpga_rawdev/base/meson.build > > +++ b/drivers/raw/ifpga_rawdev/base/meson.build > > @@ -19,7 +19,7 @@ sources =3D [ > > =C2=A0 > > =C2=A0error_cflags =3D ['-Wno-sign-compare', '-Wno-unused-value', > > =C2=A0 '-Wno-format', '-Wno-unused-but-set-variable', > > - '-Wno-strict-aliasing' > > + '-Wno-strict-aliasing', '-Wno-error=3Dformat- > > security' >=20 > For readability, should format-security be placed right beside the > Wno-format, since both go together? Makes the diff a little bigger, > but the > result would be better, I feel. >=20 > /Bruce Sure, will change that. --=20 Kind regards, Luca Boccassi