* [dpdk-dev] [PATCH 1/2] net/failsafe: support runtime Rx queues setup
2018-08-31 16:09 [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup Andrew Rybchenko
@ 2018-08-31 16:09 ` Andrew Rybchenko
2018-08-31 16:09 ` [dpdk-dev] [PATCH 2/2] net/failsafe: support runtime Tx " Andrew Rybchenko
2018-09-19 15:02 ` [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup Gaëtan Rivet
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2018-08-31 16:09 UTC (permalink / raw)
To: Gaetan Rivet; +Cc: dev, Ian Dolzhansky
From: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
Signed-off-by: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
doc/guides/nics/features/failsafe.ini | 1 +
doc/guides/rel_notes/release_18_11.rst | 1 +
drivers/net/failsafe/failsafe_intr.c | 2 +-
drivers/net/failsafe/failsafe_ops.c | 8 ++++++--
4 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini
index 74eae4a62..8bb2cac4c 100644
--- a/doc/guides/nics/features/failsafe.ini
+++ b/doc/guides/nics/features/failsafe.ini
@@ -8,6 +8,7 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
+Runtime Rx queue setup = Y
MTU update = Y
Jumbo frame = Y
Promiscuous mode = Y
diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index ad08a204f..85561dacd 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -60,6 +60,7 @@ New Features
* Support for Rx and Tx queues start and stop.
* Support for Rx and Tx queues deferred start.
+ * Support for runtime Rx queues setup.
* **Added ability to switch queue deferred start flag on testpmd app.**
diff --git a/drivers/net/failsafe/failsafe_intr.c b/drivers/net/failsafe/failsafe_intr.c
index fc6ec37fc..1c2cb71c4 100644
--- a/drivers/net/failsafe/failsafe_intr.c
+++ b/drivers/net/failsafe/failsafe_intr.c
@@ -372,7 +372,7 @@ void failsafe_rx_intr_uninstall_subdevice(struct sub_device *sdev)
for (qid = 0; qid < ETH(sdev)->data->nb_rx_queues; qid++) {
if (qid < fsdev->data->nb_rx_queues) {
fsrxq = fsdev->data->rx_queues[qid];
- if (fsrxq->enable_events)
+ if (fsrxq != NULL && fsrxq->enable_events)
rte_eth_dev_rx_intr_disable(PORT_ID(sdev),
qid);
}
diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index b2a5fe4d9..5374d0597 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -88,6 +88,8 @@ static struct rte_eth_dev_info default_infos = {
ETH_RSS_IP |
ETH_RSS_UDP |
ETH_RSS_TCP,
+ .dev_capa =
+ RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP,
};
static int
@@ -179,7 +181,7 @@ fs_set_queues_state_start(struct rte_eth_dev *dev)
for (i = 0; i < dev->data->nb_rx_queues; i++) {
rxq = dev->data->rx_queues[i];
- if (!rxq->info.conf.rx_deferred_start)
+ if (rxq != NULL && !rxq->info.conf.rx_deferred_start)
dev->data->rx_queue_state[i] =
RTE_ETH_QUEUE_STATE_STARTED;
}
@@ -240,7 +242,9 @@ fs_set_queues_state_stop(struct rte_eth_dev *dev)
uint16_t i;
for (i = 0; i < dev->data->nb_rx_queues; i++)
- dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+ if (dev->data->rx_queues[i] != NULL)
+ dev->data->rx_queue_state[i] =
+ RTE_ETH_QUEUE_STATE_STOPPED;
for (i = 0; i < dev->data->nb_tx_queues; i++)
dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
}
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH 2/2] net/failsafe: support runtime Tx queues setup
2018-08-31 16:09 [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup Andrew Rybchenko
2018-08-31 16:09 ` [dpdk-dev] [PATCH 1/2] net/failsafe: support runtime Rx queues setup Andrew Rybchenko
@ 2018-08-31 16:09 ` Andrew Rybchenko
2018-09-19 15:02 ` [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup Gaëtan Rivet
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2018-08-31 16:09 UTC (permalink / raw)
To: Gaetan Rivet; +Cc: dev, Ian Dolzhansky
From: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
Signed-off-by: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
doc/guides/nics/features/failsafe.ini | 1 +
doc/guides/rel_notes/release_18_11.rst | 2 +-
drivers/net/failsafe/failsafe_ops.c | 9 ++++++---
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini
index 8bb2cac4c..e3c4c08f2 100644
--- a/doc/guides/nics/features/failsafe.ini
+++ b/doc/guides/nics/features/failsafe.ini
@@ -9,6 +9,7 @@ Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
Runtime Rx queue setup = Y
+Runtime Tx queue setup = Y
MTU update = Y
Jumbo frame = Y
Promiscuous mode = Y
diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index 85561dacd..5d69c95b1 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -60,7 +60,7 @@ New Features
* Support for Rx and Tx queues start and stop.
* Support for Rx and Tx queues deferred start.
- * Support for runtime Rx queues setup.
+ * Support for runtime Rx and Tx queues setup.
* **Added ability to switch queue deferred start flag on testpmd app.**
diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index 5374d0597..809f9d5ff 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -89,7 +89,8 @@ static struct rte_eth_dev_info default_infos = {
ETH_RSS_UDP |
ETH_RSS_TCP,
.dev_capa =
- RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP,
+ RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
+ RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP,
};
static int
@@ -187,7 +188,7 @@ fs_set_queues_state_start(struct rte_eth_dev *dev)
}
for (i = 0; i < dev->data->nb_tx_queues; i++) {
txq = dev->data->tx_queues[i];
- if (!txq->info.conf.tx_deferred_start)
+ if (txq != NULL && !txq->info.conf.tx_deferred_start)
dev->data->tx_queue_state[i] =
RTE_ETH_QUEUE_STATE_STARTED;
}
@@ -246,7 +247,9 @@ fs_set_queues_state_stop(struct rte_eth_dev *dev)
dev->data->rx_queue_state[i] =
RTE_ETH_QUEUE_STATE_STOPPED;
for (i = 0; i < dev->data->nb_tx_queues; i++)
- dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+ if (dev->data->tx_queues[i] != NULL)
+ dev->data->tx_queue_state[i] =
+ RTE_ETH_QUEUE_STATE_STOPPED;
}
static void
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup
2018-08-31 16:09 [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup Andrew Rybchenko
2018-08-31 16:09 ` [dpdk-dev] [PATCH 1/2] net/failsafe: support runtime Rx queues setup Andrew Rybchenko
2018-08-31 16:09 ` [dpdk-dev] [PATCH 2/2] net/failsafe: support runtime Tx " Andrew Rybchenko
@ 2018-09-19 15:02 ` Gaëtan Rivet
2018-09-21 0:29 ` Ferruh Yigit
2 siblings, 1 reply; 5+ messages in thread
From: Gaëtan Rivet @ 2018-09-19 15:02 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev, Ian Dolzhansky
Hi,
for the series,
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
On Fri, Aug 31, 2018 at 05:09:36PM +0100, Andrew Rybchenko wrote:
> The patch series should be applied on top of [1] and [2].
>
> [1] https://patches.dpdk.org/project/dpdk/list/?series=1082
> [2] https://patches.dpdk.org/patch/43946/
>
> Ian Dolzhansky (2):
> net/failsafe: support runtime Rx queues setup
> net/failsafe: support runtime Tx queues setup
>
> doc/guides/nics/features/failsafe.ini | 2 ++
> doc/guides/rel_notes/release_18_11.rst | 1 +
> drivers/net/failsafe/failsafe_intr.c | 2 +-
> drivers/net/failsafe/failsafe_ops.c | 15 +++++++++++----
> 4 files changed, 15 insertions(+), 5 deletions(-)
>
> --
> 2.17.1
>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup
2018-09-19 15:02 ` [dpdk-dev] [PATCH 0/2] net/failsafe: support runtime queue setup Gaëtan Rivet
@ 2018-09-21 0:29 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-09-21 0:29 UTC (permalink / raw)
To: Gaëtan Rivet, Andrew Rybchenko; +Cc: dev, Ian Dolzhansky
On 9/19/2018 4:02 PM, Gaëtan Rivet wrote:
> Hi,
>
> for the series,
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Series applied to dpdk-next-net/master, thanks.
>
> On Fri, Aug 31, 2018 at 05:09:36PM +0100, Andrew Rybchenko wrote:
>> The patch series should be applied on top of [1] and [2].
>>
>> [1] https://patches.dpdk.org/project/dpdk/list/?series=1082
>> [2] https://patches.dpdk.org/patch/43946/
>>
>> Ian Dolzhansky (2):
>> net/failsafe: support runtime Rx queues setup
>> net/failsafe: support runtime Tx queues setup
>>
>> doc/guides/nics/features/failsafe.ini | 2 ++
>> doc/guides/rel_notes/release_18_11.rst | 1 +
>> drivers/net/failsafe/failsafe_intr.c | 2 +-
>> drivers/net/failsafe/failsafe_ops.c | 15 +++++++++++----
>> 4 files changed, 15 insertions(+), 5 deletions(-)
>>
>> --
>> 2.17.1
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread