From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 867C71DBE; Sun, 2 Sep 2018 20:37:49 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8A4080D; Sun, 2 Sep 2018 11:37:48 -0700 (PDT) Received: from ubuntu.localdomain (unknown [10.119.48.86]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2DAFB3F575; Sun, 2 Sep 2018 11:37:45 -0700 (PDT) From: Honnappa Nagarahalli To: dev@dpdk.org Cc: stable@dpdk.org, jerin.jacob@caviumnetworks.com, rasland@mellanox.com, therbert@redhat.com, honnappa.nagarahalli@arm.com, nd@arm.com Date: Sun, 2 Sep 2018 13:35:28 -0500 Message-Id: <1535913328-22493-1-git-send-email-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2018 18:37:49 -0000 GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional for ArmV8. Hence NEON related code can be enabled when __aarch64__ is defined. Bugzilla ID: 82 Cc: stable@dpdk.org Reported-by: Raslan Darawsheh Reported-by: Thomas F Herbert Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Gavin Hu Acked-by: Gavin Hu Acked-by: Jerin Jacob --- V2: * Corrected the order of contribution tags * Added Jerin's Ack config/arm/meson.build | 3 ++- mk/rte.cpuflags.mk | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 40dbc87..94cca49 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -157,7 +157,8 @@ else endif message(machine_args) -if cc.get_define('__ARM_NEON', args: machine_args) != '' +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or + cc.get_define('__aarch64__', args: machine_args) != '') dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] endif diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk @@ -89,7 +89,7 @@ CPUFLAGS += VSX endif # ARM flags -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) CPUFLAGS += NEON endif -- 2.7.4