From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 785785A for ; Mon, 3 Sep 2018 11:34:59 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id c14-v6so445655wmb.4 for ; Mon, 03 Sep 2018 02:34:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=2+uhBj0eCxAtR8lnzdIoRaIIeO6PI7lJAp6mz6p8MAw=; b=UsgdaRuvPeXmXamGQhybjQn5y9zfKdTKUdPA1NGqB7ZYM2Wr4AUSugtwMu5xVaG8Wy 6yLaxU6hKkIhPXhY7MDaBCYjNSirNrtMZgWHoeeDMBGR5hF8aaHkZ9t2SGvcVdCesSmD LvY5C/OWRBuoEmAjfgf0S2x9S1VujUneamx40jXEX1AeMji/A1j0THkq7I84TyYQ1laA SlHNneODEMY3c7fglb1h54tjZV3cwdeB4QuTZaz816iSrumpye1TKSn/joQ3Zhj4Z2iV cg0dvA8f37aacb3d/ACKkLyiZdGXn6P2m+8ADuYgVgvcK1z7jVQRR3DpHNh7Yjp/aCDn g7TQ== X-Gm-Message-State: APzg51DJZr/dhJBuepEtQ+XyrtReC05f+oO2g2mrWYSm8LIdGt10Ulue 0Bby/bF8PAXGMvfCIUk/WT0= X-Google-Smtp-Source: ANB0Vdb4s46F2L3BOfYyR9Mkr2LQsYweLkZ25IK5p2dASX+Y4DDvnvQmanelNu5+5EKhuw0D1oqXMA== X-Received: by 2002:a1c:1748:: with SMTP id 69-v6mr4512793wmx.75.1535967299171; Mon, 03 Sep 2018 02:34:59 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 66-v6sm16396300wmw.34.2018.09.03.02.34.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 02:34:58 -0700 (PDT) Message-ID: <1535967297.11823.41.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon Cc: dev@dpdk.org, bruce.richardson@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com Date: Mon, 03 Sep 2018 10:34:57 +0100 In-Reply-To: <1581479.dLBctXLE49@xps> References: <20180831182055.30772-1-bluca@debian.org> <20180831182055.30772-5-bluca@debian.org> <1581479.dLBctXLE49@xps> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] build: generate API documentation with Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 09:34:59 -0000 On Mon, 2018-09-03 at 03:09 +0200, Thomas Monjalon wrote: > 31/08/2018 20:20, Luca Boccassi: > > Both a configuration-time "enable_docs" boolean option and an > > optional > > 'ninja doc' target are available. Note that due to a Meson bug for > > now > > the latter will only build, but not install the files. > >=20 > > Signed-off-by: Luca Boccassi > > --- > > =C2=A0doc/api/generate_doxygen.sh | 10 ++++++++ > > =C2=A0doc/api/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| 51 > > +++++++++++++++++++++++++++++++++++++ > > =C2=A0doc/build-sdk-meson.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2= =A02 ++ > > =C2=A0doc/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A04 +++ > > =C2=A0meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A03 +++ > > =C2=A0meson_options.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0|=C2=A0=C2=A02 ++ > > =C2=A06 files changed, 72 insertions(+) >=20 > You use generate_doxygen.sh only with meson? > Shouldn't we use the same in mk/rte.sdkdoc.mk? I was kinda hoping somebody would be able to suggest an alternative that avoids the need for generate_doxygen.sh - the issue being that with Meson's "custom_target" you can't specify a subdirectory in input/ouput (and the directory is generated at build time so can't have a meson.build in it), and also you cannot use the same "output" twice. So I can't see a way to have an additional custom_target to run the CSS generation, hence the script. Changing the makefile to use the script will make it a bit more complicated, as the doxygen file will need to be generated rather than passed by piping stout/in, so the rule will have to be split into 3: create directory -> create file -> call doxygen. Not sure it's worth it? --=20 Kind regards, Luca Boccassi