From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 958ED2716
 for <dev@dpdk.org>; Fri,  1 Apr 2016 12:30:03 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id 127so15050988wmu.1
 for <dev@dpdk.org>; Fri, 01 Apr 2016 03:30:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=LkflWILLhnm2oGkhCTgWPlaxwNVOsHxZ9+hbV2h3ceo=;
 b=vbaGX6cpuv+v6VMiRusSKdfM0QswZqgscKd/7I4JpBNPaubNdnPcuZ+grcSxIv/m7y
 I1vv2KXZ8J2/yiN5xtA3d7CMElrWdNfHTxOX5dwxcEo+nhZiv7eb1DPTDufZQ6Jh6YQu
 36E49ZUhLil0Zvygg+ZC8r0ookCiUoRuElQMxo2eVp1ABD6hIU9N2+mVphX1NmLOcCsJ
 11B74uLkr7V4YeebBjCtME94TENtoF3/ppIsyOb+k1UYmfuprLMsF23auuqW5wfhNTIt
 PmgPfpwG9VojOY1AbOvn7FTLg0d9so3pN/fk+QfcXY6IReeN3j910bshIK0phk3/dnxr
 fYVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=LkflWILLhnm2oGkhCTgWPlaxwNVOsHxZ9+hbV2h3ceo=;
 b=HcA4genHjWVV3TNr5CmEw6HxFgyUS5rZeooa9sSdCe8/s8NrdFV1r+Ntp1TCRGGnHw
 IWeQrB/iZ/EOWaMLIPbASbApnMMncQo/lZwZBF0sMJ+TaMCdjShjQWE45OsV3osZ2mRV
 82ctve/gwIpkPRWkQ6583QyMuvzceE+i+ajdCm7UMA8UPOf5IblMLt0TsmHmk/cvXS4r
 OETkoWjrWb8GIBDopr7wjei8hJF3x6Lpry8B+9u/4pzz/o15gv4Hibda8sDdkQr/zXOw
 PMl9qZCKgqYOh1spoCQNhOyOQOJIIEFyJopYHh5yg3sFUMOJPDkqUn5KaterjZ5kbZc6
 Bohg==
X-Gm-Message-State: AD7BkJJO75wqSsOBf+K7dzxFct5TCpu6WXZsUz+hj/TVbHHEpplJxOO8jkb7qANTIUx8QOSK
X-Received: by 10.194.179.227 with SMTP id dj3mr20386892wjc.50.1459506603391; 
 Fri, 01 Apr 2016 03:30:03 -0700 (PDT)
Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91])
 by smtp.gmail.com with ESMTPSA id t4sm2141453wmf.8.2016.04.01.03.30.02
 (version=TLSv1/SSLv3 cipher=OTHER);
 Fri, 01 Apr 2016 03:30:02 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Fan Zhang <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org
Date: Fri, 01 Apr 2016 12:28:07 +0200
Message-ID: <1536333.27nVV74cJ2@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1459504512-6114-1-git-send-email-roy.fan.zhang@intel.com>
References: <1459504512-6114-1-git-send-email-roy.fan.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] port: fix source and sink port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Apr 2016 10:30:03 -0000

The title don't talk about pcap. Is it touching only pcap?

2016-04-01 10:55, Fan Zhang:
> Fixes: eb5f411 ("port: add pcap file dump")
> 
> This patch fixes pcap supporting logic. The fix includes:

What was the issue?

> * Adding logic to detect illegal parameter.
> * Clearer error message display.
> * Remove unnecessary RTE_NEXT_ABI macro warping.
> * Code clean-up

Maybe these changes can be split?