From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id BAF494F9B for ; Fri, 7 Sep 2018 18:56:38 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id a108-v6so15594247wrc.13 for ; Fri, 07 Sep 2018 09:56:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=pWPR+jlj1fVsjnaawj1wAiJd6+LMZoI8uVVNElpWsPI=; b=GuQ6Er6huPV6kW4DDUH7c00LxRe88QTwdS9g0m0f7vzAPWVTT4wTA2sfSxjpZiW7Gq Z1sMpC98vpK+3FGB4iw//OGCE22wlcSyf12XU9rRuYUoq4ygKxNO8Ni5SrsJQCBsVjoC keOraQ+qFe2iqzM3xOgYaIgkAiyrG3QToYS5eqSu2D0AKGwWFh/ttuqsfuzuTNuwMpXI NZmYjPNwbZn1magbbh4kEUW5YtBwzQBRJ37WdG1hJuyQMAyP7cPjX5kJFDwO8qNDSvZT oZmhKE74Ti7yI+xF9qeEXYUHz8URbPxT/p3VVJN2ePyGSN8ymNZ85zA742AHQ3Sso8QY EAow== X-Gm-Message-State: APzg51C6Mc8Ejx258pIJQ0UY05gV8CLhnDwbzJTErzQoWT88nDAZEskp v6d34FzEl6MCEEmdGzoArEVdSr/ltQQ= X-Google-Smtp-Source: ANB0VdYoFXS4lejiREENVjQveFD4FmSzU3firA6tIdlum42gDSat/DgfMLVjGeAhY/QqKgRqaWHLcA== X-Received: by 2002:adf:f906:: with SMTP id b6-v6mr6693009wrr.28.1536339398527; Fri, 07 Sep 2018 09:56:38 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id a9-v6sm7463916wmf.28.2018.09.07.09.56.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Sep 2018 09:56:37 -0700 (PDT) Message-ID: <1536339397.12545.18.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: Thomas Monjalon , dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com Date: Fri, 07 Sep 2018 17:56:37 +0100 In-Reply-To: <20180907161322.GA24984@bricha3-MOBL.ger.corp.intel.com> References: <20180831182055.30772-1-bluca@debian.org> <20180831182055.30772-2-bluca@debian.org> <1746678.vtfpdfx8nV@xps> <1535965627.11823.37.camel@debian.org> <20180907161322.GA24984@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/4] mk: use script to generate examples.dox X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Sep 2018 16:56:38 -0000 On Fri, 2018-09-07 at 17:13 +0100, Bruce Richardson wrote: > On Mon, Sep 03, 2018 at 10:07:07AM +0100, Luca Boccassi wrote: > > On Mon, 2018-09-03 at 02:54 +0200, Thomas Monjalon wrote: > > > 31/08/2018 20:20, Luca Boccassi: > > > > +# SC2129 - avoid multiple individual redirects > > >=20 > > > What is SC2129 ? > >=20 > > shellcheck - will clarify in v2 > >=20 > > > > +{ \ > > > > +=C2=A0=C2=A0=C2=A0=C2=A0printf '/**\n'; \ > > > > +=C2=A0=C2=A0=C2=A0=C2=A0printf '@page examples DPDK Example Progra= ms\n\n'; \ > > > > +=C2=A0=C2=A0=C2=A0=C2=A0find "${EXAMPLES_DIR}" -type f -name '*.c'= -printf '@examp > > > > le > > > > examples/%P\n' | LC_ALL=3DC sort; \ > > > > +=C2=A0=C2=A0=C2=A0=C2=A0printf '*/\n'; \ > > > > +} > "${API_EXAMPLES}" > > >=20 > > > Why using backslashes (continuation lines)? > >=20 > > Good point, will remove in v2 > >=20 >=20 > Agree, rather than using continuation lines, I suggest one of the > following: > * use exec > ${API_EXAMPLES} at the top of the script > * let the script just print to stdout and have make/meson put that in > the > =C2=A0 output file for you. >=20 > /Bruce exec > works and checkbashism is also happy with it, so used that in v2 --=20 Kind regards, Luca Boccassi