Re: [PATCH 11/11] crypto/cnxk: add PMD API to get qp stats

[Thomas Monjalon <thomas@monjalon.net>]

05/09/2024 09:46, Tejasree Kondoj:
> From: Anoob Joseph <anoobj@marvell.com>
> 
> Add PMD API to get CPT LF(QP) stats.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
> +struct rte_pmd_cnxk_crypto_qp_stats {
> +	/** Packet counter of the packets that used CPT context cache and was encrypted */
> +	uint64_t ctx_enc_pkts;
> +	/** Byte counter of the packets that used CPT context cache and was encrypted */
> +	uint64_t ctx_enc_bytes;
> +	/** Packet counter of the packets that used CPT context cache and was decrypted */
> +	uint64_t ctx_dec_pkts;
> +	/** Byte counter of the packets that used CPT context cache and was decrypted */
> +	uint64_t ctx_dec_bytes;
> +};
[...]
> --- a/drivers/crypto/cnxk/version.map
> +++ b/drivers/crypto/cnxk/version.map
> @@ -10,6 +10,7 @@ EXPERIMENTAL {
>  	rte_pmd_cnxk_crypto_cptr_get;
>  	rte_pmd_cnxk_crypto_cptr_read;
>  	rte_pmd_cnxk_crypto_cptr_write;
> +	rte_pmd_cnxk_crypto_qp_stats_get;

I don't think it is a good idea.
You should introduce xstats in cryptodev, the same as in ethdev.