From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
by dpdk.org (Postfix) with ESMTP id 0E2641B19
for <dev@dpdk.org>; Tue, 11 Sep 2018 15:09:32 +0200 (CEST)
Received: by mail-wm0-f65.google.com with SMTP id 207-v6so909748wme.5
for <dev@dpdk.org>; Tue, 11 Sep 2018 06:09:32 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
:references:content-transfer-encoding:mime-version;
bh=/NPtFH+DwTUNGHReoAtmBtenizenj5ItB3KdF/ABNFM=;
b=YS3FSbXzw8Zo4ZEyxnxm+8S8QRfK97QCKTxW2HlWhbFJd23dOA8LGjbdClT2KA7OOc
xhSq954Lr6Nzwcs2+B3VKMVgwmBO5V5Oa1dMh01VXMLd+qH5eq9ov28HNLaO1lHCyOAS
6LR24GRkNcB0pq5qLZWUcXtEB34nbHM+akftGymRGebkjw6G/KXrsPCF4cl2uhwuu/Qm
UQYhxzRqokqXY3zfGnbEfZs8I0oGYjseV2A8nE/6nMbEuwkSNz3KV5WIQWJAi14TJpur
tT6AWf3P85ZfNC1gebIWWwaZkiUHJrVNuGRIxPfTuwuBOFTSRXt+BOsDslEdVD38Ri4L
WbQA==
X-Gm-Message-State: APzg51BB8WU9/eUIFGQXaKoyCYPuxHMAtgAsVC3bFyGRWkHgEqw2vP+A
yGSUwsGCe6bn07HQdf+n1CA=
X-Google-Smtp-Source: ANB0VdbDDoP/RPO2SeHg6wfBBP3I09Z1h1bWCLG95PXWVqcbFetzk6QX3sDm/6tHEh/opdzVb2wnjQ==
X-Received: by 2002:a1c:5c4:: with SMTP id 187-v6mr1392616wmf.10.1536671371700;
Tue, 11 Sep 2018 06:09:31 -0700 (PDT)
Received: from localhost ([2001:1be0:110d:fcfe:34de:1298:1768:55da])
by smtp.gmail.com with ESMTPSA id t9-v6sm12511292wmf.1.2018.09.11.06.09.30
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 11 Sep 2018 06:09:30 -0700 (PDT)
Message-ID: <1536671370.10952.18.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>,
t@bricha3-MOBL.ger.corp.intel.com
Cc: dev@dpdk.org, keith.wiles@intel.com, roy.fan.zhang@intel.com,
jingjing.wu@intel.com, wenzhuo.lu@intel.com, rasesh.mody@cavium.com,
harish.patil@cavium.com, shahed.shaikh@cavium.com, amr.mokhtar@intel.com,
shijith.thotton@cavium.com, ssrinivasan@cavium.com, liang.j.ma@intel.com,
peter.mccarthy@intel.com, jerin.jacob@caviumnetworks.com,
maciej.czekaj@caviumnetworks.com, arybchenko@solarflare.com,
ashish.gupta@cavium.com, yongwang@vmware.com, thomas@monjalon.net
Date: Tue, 11 Sep 2018 14:09:30 +0100
In-Reply-To: <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com>
References: <20180910200415.8340-1-bluca@debian.org>
<20180910200415.8340-8-bluca@debian.org>
<20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after
library file name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Sep 2018 13:09:32 -0000
On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote:
> On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote:
> > The library is called librte_pmd_lio, so rename the map file and
> > set
> > the name in the meson file so that the built library names with
> > meson
> > and legacy makefiles are the same
> >=20
> > Fixes: bad475c03fee ("net/liquidio: add to meson build")
> > Cc: stable@dpdk.org
> >=20
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
>=20
> Rather than doing this renaming, can we instead add a symlink in the
> install phase to map the old name to the new one? I'd like to see the
> consistency of directory name, map filename and driver name enforced
> strictly in the build system. Having exceptions is a pain.
>=20
> /Bruce
We could, but the pain gets shifted on packagers then - what about
renaming the directory entirely to net/lio?
--=20
Kind regards,
Luca Boccassi