From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id D987A4C91 for ; Tue, 11 Sep 2018 15:38:54 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id o18-v6so1052028wmc.0 for ; Tue, 11 Sep 2018 06:38:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=IkfZnXAJppCoAAstIEc49mMPAN1yu4+5P+7YMjUpyHY=; b=qMmcrBo4pS9qdaiKxPHfGNi7a9C216T0fSE+NOcXz8LUrG4LOS/IZI4BBjqOcmi/pG wYLG1zwjwKeRFtCPayD821pXO6j6q5/PXlWWyBuPhvdTxZ12Iyy/wGAXpI2thdVpKQfT kn2VdxaCCvzYP96wGhTbJBnd3HIUJV6J7rn++x3maTelj7hdmXbnzMOb/UMPYJRbpXs9 K/XiTe22AyIGSS4yOYrKn9Gumaz4scVSwzrMLBmseoba1ixiZFIgS8emhcZQ1AemcaXT 8m2PqloW5lrzZ22fmuMRSlOvflSY3zuni7vyHoSBtyCd8NRI7etXwf7XnZfS2cuSgpk5 HW/w== X-Gm-Message-State: APzg51DCvUkiX/sY7A4evOX/W7yQVec0CtRcBlU4DF92MqmL0B95yd6w J2VC7WemH7vyYjNSbSMRwTI= X-Google-Smtp-Source: ANB0VdZxSba/swh689mmL+IDj+xAX7GldeliEQIGTj2nYOkAuo17YF34KR9ebloB6qE8xb759ovQ4w== X-Received: by 2002:a1c:88a:: with SMTP id 132-v6mr1467695wmi.9.1536673134403; Tue, 11 Sep 2018 06:38:54 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:34de:1298:1768:55da]) by smtp.gmail.com with ESMTPSA id x24-v6sm34441451wrd.13.2018.09.11.06.38.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 06:38:52 -0700 (PDT) Message-ID: <1536673132.10952.20.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 11 Sep 2018 14:38:52 +0100 In-Reply-To: <20180911133017.GC11744@bricha3-MOBL.ger.corp.intel.com> References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-8-bluca@debian.org> <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com> <1536671370.10952.18.camel@debian.org> <20180911133017.GC11744@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 13:38:55 -0000 On Tue, 2018-09-11 at 14:30 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > > > The library is called librte_pmd_lio, so rename the map file > > > > and > > > > set > > > > the name in the meson file so that the built library names with > > > > meson > > > > and legacy makefiles are the same > > > >=20 > > > > Fixes: bad475c03fee ("net/liquidio: add to meson build") > > > > Cc: stable@dpdk.org > > > >=20 > > > > Signed-off-by: Luca Boccassi > > >=20 > > > Rather than doing this renaming, can we instead add a symlink in > > > the > > > install phase to map the old name to the new one? I'd like to see > > > the > > > consistency of directory name, map filename and driver name > > > enforced > > > strictly in the build system. Having exceptions is a pain. > > >=20 > > > /Bruce > >=20 > > We could, but the pain gets shifted on packagers then - what about > > renaming the directory entirely to net/lio? > >=20 >=20 > It is still an issue with packagers if the symlinks are created as > part of > the install step of DPDK itself (which is what I was intending)? I > was > thinking of adding a new post-install script for the backward > compatible > renames. At least for Debian/Ubuntu, if I tell the tools that package libfoo1 needs to have libfoo.so.1.2.3, that's what it will do, without following symlinks. So a broken link will be installed in the system, unless I start tracking what symlinks are there and adding them manually to the package they belong to. There's also the fact that by policy the library package names should match the file name of the library and its ABI revision, so libfoo.so.1.2.3 should be in libfoo1 pkg vy policy - if they mismatch, some linters tools are going to yell at me at the very least. > As for renaming the directory, I don't mind, but I'll let the driver > maintainers comment on their thoughts on it. >=20 > /Bruce --=20 Kind regards, Luca Boccassi