From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 0B74F4C91 for ; Tue, 11 Sep 2018 15:41:39 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id u12-v6so26054204wrr.4 for ; Tue, 11 Sep 2018 06:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=oJKV6GyFXTA7XI1hfpRP+Tn8xIH1Km6xhvsyXRmmf50=; b=s2z7XtRgrSJojA3O3rMLOYFpKpQBBu1EEnub0/3h6F2/0rB3oOvmZiggb8FLTKKemp XT7+He7TJweZCtrfK6P3d2Oi+1xq/t3ekT7NcAn5t2/X5OONYSyqnW0hHnsu9edl0Lqc txWLp9pJU0iD5KouGhqE/vqC5T4j3FN/642gx7PrOlqTRwDBfZ3TWWEAYtM5M2YGZTYp vSC9BlAs6ZhOf4bPBmT5BV6XCqtpXd5FyE9DurtixEDLX3+X34NSGeiobDdyPpdbi/XL cINc9eO3xhH6U7tj0zkCTW/p1NBtcWFuIjnwtMagmftsMwU3OtBZ+ou+LCHcAYzHSxs6 oAeQ== X-Gm-Message-State: APzg51C6xZQVaKN5mBLMeSJrbLjkPX720H4nLRNarGXCMtccKvM8cDHp c18IwXK6q/2Ij0++R1RcD0IEIGpS X-Google-Smtp-Source: ANB0VdZTX4SaEN3K28YLHkhfoewRnU5rFpc/IFM8jqgYG1eDxO/tuOmnH6SeUIy6Z6S97bGIApSzZA== X-Received: by 2002:adf:8167:: with SMTP id 94-v6mr19565016wrm.127.1536673298648; Tue, 11 Sep 2018 06:41:38 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:34de:1298:1768:55da]) by smtp.gmail.com with ESMTPSA id l24-v6sm43043934wrb.65.2018.09.11.06.41.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 06:41:37 -0700 (PDT) Message-ID: <1536673296.10952.22.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 11 Sep 2018 14:41:36 +0100 In-Reply-To: <20180911133215.GD11744@bricha3-MOBL.ger.corp.intel.com> References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-8-bluca@debian.org> <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com> <1536671370.10952.18.camel@debian.org> <20180911133215.GD11744@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 13:41:39 -0000 On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > > > The library is called librte_pmd_lio, so rename the map file > > > > and > > > > set > > > > the name in the meson file so that the built library names with > > > > meson > > > > and legacy makefiles are the same > > > >=20 > > > > Fixes: bad475c03fee ("net/liquidio: add to meson build") > > > > Cc: stable@dpdk.org > > > >=20 > > > > Signed-off-by: Luca Boccassi > > >=20 > > > Rather than doing this renaming, can we instead add a symlink in > > > the > > > install phase to map the old name to the new one? I'd like to see > > > the > > > consistency of directory name, map filename and driver name > > > enforced > > > strictly in the build system. Having exceptions is a pain. > > >=20 > > > /Bruce > >=20 > > We could, but the pain gets shifted on packagers then - what about > > renaming the directory entirely to net/lio? >=20 > For packagers, what sort of ABI compatibility guarantees do you try > and > keep between releases. Is this something that just needs a one- > release ABI > announcement, as with other ABI changes? >=20 > /Bruce Currently in Debian/Ubuntu we are using the ABI override (because of the sticky ABI breakage issue) so the filenames and package names are different on every release anyway. So in theory we could change the name of the libs and packages, but what I'm mostly worried about is keeping consistency and some level of compatibility between old and new build systems, isn't that an issue? --=20 Kind regards, Luca Boccassi