From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 1BFC02BFA for ; Tue, 11 Sep 2018 18:05:18 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id 20-v6so26607630wrb.12 for ; Tue, 11 Sep 2018 09:05:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=ouFTLKw9WeNWGIrZUPEBTfIcIcV7B8dhurWylYMcUK4=; b=bi/Ps087zu9n/m7NsPmJddksOQCKPOa1U361+VMVl9TIdnDMFNKlVhI4RwFJiPDzhG gpEJbbetlz2B4ckpiTDoF4FDh3ZOjjSRNtXpE0li2onW/x0iYM/lb/YaZUUcPPMPE2jG 1KG5fN82vbWUyoFJj+n8WR1jtaxpAEzm3OE1kJbtArfc0CEO5M8e8ZoC8ZxoD/4zkqoF NHCD9bN3qMt03bkuitlg21inm0+rSqgx+YuyXhri4S5b1Yvy/luBgIzwK0bGFg2/+lmo QWbNflfw3p2Z7V1vHzoNu1k4D3V8nI3baTPlbv+6R4b+hPHMVpSovJQQzxMPUOufRHYs V8xQ== X-Gm-Message-State: APzg51Bhz7avVMtIiSeKkQEh0D7mY2xT+34IgPrhH9xtcPIElqxkxIRF bja1klJDLfgQ8CVYHxOA2Ug= X-Google-Smtp-Source: ANB0Vda6KzY5CXxnoRhMWPp+chvrN82Qzko+3eaS/DyzpZ4t/5gaYl3bc7wq1aNz9u3l0XK0n9toww== X-Received: by 2002:adf:806d:: with SMTP id 100-v6mr18592744wrk.23.1536681917564; Tue, 11 Sep 2018 09:05:17 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id h10-v6sm2056289wmf.44.2018.09.11.09.05.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 09:05:15 -0700 (PDT) Message-ID: <1536681915.10952.23.camel@debian.org> From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 11 Sep 2018 17:05:15 +0100 In-Reply-To: <20180911140614.GA22976@bricha3-MOBL.ger.corp.intel.com> References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-8-bluca@debian.org> <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com> <1536671370.10952.18.camel@debian.org> <20180911133215.GD11744@bricha3-MOBL.ger.corp.intel.com> <1536673296.10952.22.camel@debian.org> <20180911140614.GA22976@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 16:05:18 -0000 On Tue, 2018-09-11 at 15:06 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 02:41:36PM +0100, Luca Boccassi wrote: > > On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote: > > > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > > > > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > > > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi > > > > > wrote: > > > > > > The library is called librte_pmd_lio, so rename the map > > > > > > file > > > > > > and > > > > > > set > > > > > > the name in the meson file so that the built library names > > > > > > with > > > > > > meson > > > > > > and legacy makefiles are the same > > > > > >=20 > > > > > > Fixes: bad475c03fee ("net/liquidio: add to meson build") > > > > > > Cc: stable@dpdk.org > > > > > >=20 > > > > > > Signed-off-by: Luca Boccassi > > > > >=20 > > > > > Rather than doing this renaming, can we instead add a symlink > > > > > in > > > > > the > > > > > install phase to map the old name to the new one? I'd like to > > > > > see > > > > > the > > > > > consistency of directory name, map filename and driver name > > > > > enforced > > > > > strictly in the build system. Having exceptions is a pain. > > > > >=20 > > > > > /Bruce > > > >=20 > > > > We could, but the pain gets shifted on packagers then - what > > > > about > > > > renaming the directory entirely to net/lio? > > >=20 > > > For packagers, what sort of ABI compatibility guarantees do you > > > try > > > and > > > keep between releases. Is this something that just needs a one- > > > release ABI > > > announcement, as with other ABI changes? > > >=20 > > > /Bruce > >=20 > > Currently in Debian/Ubuntu we are using the ABI override (because > > of > > the sticky ABI breakage issue) so the filenames and package names > > are > > different on every release anyway. > >=20 > > So in theory we could change the name of the libs and packages, but > > what I'm mostly worried about is keeping consistency and some level > > of > > compatibility between old and new build systems, isn't that an > > issue? > >=20 >=20 > It's a good question, and I suspect everyone will have their own > opinion. >=20 > Personally, I take the view that moving build system involves quite a > number of changes anyway, so we should take the opportunity to clean > up a > few other things at the same time. This is why I'm so keep on trying > to > keep everything consistent as far as possible throughout the system > and not > put in special cases. For many of these a) if we put in lots of name > overrides now we'll probably never get rid of them, and b) it's more > likely > that future drivers will adopt the same technique to have different > naming > of drivers and directories. >=20 > However, if keeping sonames consistent is a major concern, then > perhaps we > should look to rename some directories, like you suggested before. >=20 > /Bruce Actually I tend to agree, it would be better to make the libraries consistent, so I'm fine with having to deal with it once in packaging. I'll send a v2 without most of the renames. --=20 Kind regards, Luca Boccassi