DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ziye Yang <ziye.yang@intel.com>
To: dev@dpdk.org
Cc: konstantin.ananyev@intel.com, Ziye Yang <optimistyzy@gmail.com>
Subject: [dpdk-dev] [PATCH v8] linuxapp, eal: Fix the memory leak issue of logid
Date: Wed, 12 Sep 2018 09:31:50 +0800	[thread overview]
Message-ID: <1536715910-38320-1-git-send-email-ziye.yang@intel.com> (raw)
In-Reply-To: <1536125954-46632-1-git-send-email-ziye.yang@intel.com>

From: Ziye Yang <optimistyzy@gmail.com>

This patch is used to fix the memory leak issue of logid.
We use the ASAN test in SPDK when intergrating DPDK and
find this memory leak issue.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>
---
 lib/librte_eal/linuxapp/eal/eal.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index e59ac65..46494f9 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -793,7 +793,8 @@ static void rte_eal_init_alert(const char *msg)
 	int i, fctret, ret;
 	pthread_t thread_id;
 	static rte_atomic32_t run_once = RTE_ATOMIC32_INIT(0);
-	const char *logid;
+	const char *p;
+	static char logid[PATH_MAX];
 	char cpuset[RTE_CPU_AFFINITY_STR_LEN];
 	char thread_name[RTE_MAX_THREAD_NAME_LEN];
 
@@ -810,9 +811,8 @@ static void rte_eal_init_alert(const char *msg)
 		return -1;
 	}
 
-	logid = strrchr(argv[0], '/');
-	logid = strdup(logid ? logid + 1: argv[0]);
-
+	p = strrchr(argv[0], '/');
+	snprintf(logid, sizeof(logid), "%s", (p ? p + 1 : argv[0]));
 	thread_id = pthread_self();
 
 	eal_reset_internal_config(&internal_config);
-- 
1.9.3

  parent reply	other threads:[~2018-09-12  1:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  5:39 [dpdk-dev] [PATCH v5] " Ziye Yang
2018-09-10 11:54 ` Ananyev, Konstantin
2018-09-10 11:58   ` Yang, Ziye
2018-09-10 12:19     ` Ananyev, Konstantin
2018-09-10 12:23       ` Yang, Ziye
2018-09-10 13:46 ` [dpdk-dev] [PATCH v6] " Ziye Yang
2018-09-11  1:27 ` [dpdk-dev] [PATCH v7] " Ziye Yang
2018-09-11 10:09   ` Ananyev, Konstantin
2018-09-11 13:47   ` Aaron Conole
2018-09-11 14:06     ` Ananyev, Konstantin
2018-09-11 15:27       ` Aaron Conole
2018-09-13 13:28       ` Aaron Conole
2018-09-12  1:31 ` Ziye Yang [this message]
2018-10-16 15:33   ` [dpdk-dev] [PATCH v8] " Ferruh Yigit
2018-10-22  8:00   ` Thomas Monjalon
2018-10-28 10:41     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1536715910-38320-1-git-send-email-ziye.yang@intel.com \
    --to=ziye.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=optimistyzy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).