From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <amo@semihalf.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
[209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 837FF32A5
for <dev@dpdk.org>; Wed, 19 Sep 2018 17:01:45 +0200 (CEST)
Received: by mail-lf1-f66.google.com with SMTP id v77-v6so5432317lfa.6
for <dev@dpdk.org>; Wed, 19 Sep 2018 08:01:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=semihalf-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:in-reply-to:references;
bh=Bvyyjer4tCSWHB5TCSAmmCewWH7uK+vdMrlZXFKB6xg=;
b=ZKbWmXoUR4ERzDdsGt29MWxXEb4fAk/NoKgnwdDQO2A4QN4CafOFYzVZZ7pvbTq88J
UwNnhNGdjppvXK3Ecry4O2o8PUBVhtNiz/zJHBZANo5FKDUL7uDiibN91HLE9RL3jyia
iXndT1aI9gRrT3nvBLKii4PlrafE8njUMXpnQi82JOFpZtqfW3guxkKstijpvsuqSNds
0YCkkWX95D6tYbqjjb/XEhW2tSkPSD/Uc2KA/18HCGsdE8KALfgRn1BKsLeAReesEQcV
0OFNRTBuZVWPOqEQhRVnvMNpqp5+Z/wsTVTtmzezHQwEPpOkrGjJUEveuzK+lj1wf3Ui
aKJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=Bvyyjer4tCSWHB5TCSAmmCewWH7uK+vdMrlZXFKB6xg=;
b=VrpqD9cnfQjYeXhijdv6u3JRw83t9d0e4H+dNpMOeudn1D/SnuwJ63URq/Vs/A+aVj
+uzrEcosU6uXrxtxwETefYZ/3loLddsNXHYWRQkj6JgOnX2Cu2LLFUS5BdxOn+Ld+oYM
Rs5hzZfRFINX2f2/67Ov8Kkht0R4GKQQGW6bRYsZAcHLLCl1r7h94HzJyI2A1bbk8ivD
o7h5xLuZZrtrAydDy348vcizLDCx/F8nZXz25rbbRS7wj0Yhw+R68Sg6F04tofPjv/A3
IRb6QMYczr2zAQagPVEkmNutQUayVvK2PjGe8DsvULl+ezLV/hjOzx+YaPIKtX1br5dO
EvYQ==
X-Gm-Message-State: APzg51BHQ8a2N4xAWQVhLYdWsWNNz/6wlQXS79dC+sNnKRZHvw4VeW0e
yTlXgNr6DzCliZ9aZHY+cGbfgGrq4VM=
X-Google-Smtp-Source: ANB0VdZhOk7ubmYtLrGao11O31m18VER6qYmDwzStwlTEdveY/a+meMDxdcP12xWvzHSA/a0cdBoKw==
X-Received: by 2002:a19:18c5:: with SMTP id
66-v6mr10401742lfy.133.1537369304375;
Wed, 19 Sep 2018 08:01:44 -0700 (PDT)
Received: from amok.semihalf.local (31-172-191-173.noc.fibertech.net.pl.
[31.172.191.173]) by smtp.googlemail.com with ESMTPSA id
z3-v6sm1107711lfj.89.2018.09.19.08.01.43
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Wed, 19 Sep 2018 08:01:43 -0700 (PDT)
From: Andrzej Ostruszka <amo@semihalf.com>
To: dev@dpdk.org
Cc: mw@semihalf.com,
zr@semihalf.com,
tdu@semihalf.com,
nadavh@marvell.com
Date: Wed, 19 Sep 2018 17:01:32 +0200
Message-Id: <1537369294-17099-7-git-send-email-amo@semihalf.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1537369294-17099-1-git-send-email-amo@semihalf.com>
References: <1535720386-18775-1-git-send-email-amo@semihalf.com>
<1537369294-17099-1-git-send-email-amo@semihalf.com>
Subject: [dpdk-dev] [PATCH v4 6/8] net/mvneta: add MAC filtering
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2018 15:01:45 -0000
From: Zyta Szpak <zr@semihalf.com>
Add callbacks for adding/removing MAC addresses.
Signed-off-by: Yelena Krivosheev <yelena@marvell.com>
Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
Signed-off-by: Zyta Szpak <zr@semihalf.com>
---
doc/guides/nics/features/mvneta.ini | 1 +
doc/guides/nics/mvneta.rst | 1 +
drivers/net/mvneta/mvneta_ethdev.c | 69 +++++++++++++++++++++++++++++++++++++
3 files changed, 71 insertions(+)
diff --git a/doc/guides/nics/features/mvneta.ini b/doc/guides/nics/features/mvneta.ini
index 6a140a3..59c9c36 100644
--- a/doc/guides/nics/features/mvneta.ini
+++ b/doc/guides/nics/features/mvneta.ini
@@ -9,6 +9,7 @@ Link status = Y
MTU update = Y
Jumbo frame = Y
Promiscuous mode = Y
+Unicast MAC filter = Y
CRC offload = Y
L3 checksum offload = Y
L4 checksum offload = Y
diff --git a/doc/guides/nics/mvneta.rst b/doc/guides/nics/mvneta.rst
index 1912c3e..b21581b 100644
--- a/doc/guides/nics/mvneta.rst
+++ b/doc/guides/nics/mvneta.rst
@@ -32,6 +32,7 @@ Features of the MVNETA PMD are:
- Jumbo frame
- MTU update
- Promiscuous mode
+- Unicast MAC filter
- Link status
- CRC offload
- L3 checksum offload
diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
index 0f4dece..fdd6eb0 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -599,6 +599,73 @@ mvneta_promiscuous_disable(struct rte_eth_dev *dev)
}
/**
+ * DPDK callback to remove a MAC address.
+ *
+ * @param dev
+ * Pointer to Ethernet device structure.
+ * @param index
+ * MAC address index.
+ */
+static void
+mvneta_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)
+{
+ struct mvneta_priv *priv = dev->data->dev_private;
+ char buf[ETHER_ADDR_FMT_SIZE];
+ int ret;
+
+ if (!priv->ppio)
+ return;
+
+ ret = neta_ppio_remove_mac_addr(priv->ppio,
+ dev->data->mac_addrs[index].addr_bytes);
+ if (ret) {
+ ether_format_addr(buf, sizeof(buf),
+ &dev->data->mac_addrs[index]);
+ MVNETA_LOG(ERR, "Failed to remove mac %s", buf);
+ }
+}
+
+/**
+ * DPDK callback to add a MAC address.
+ *
+ * @param dev
+ * Pointer to Ethernet device structure.
+ * @param mac_addr
+ * MAC address to register.
+ * @param index
+ * MAC address index.
+ * @param vmdq
+ * VMDq pool index to associate address with (unused).
+ *
+ * @return
+ * 0 on success, negative error value otherwise.
+ */
+static int
+mvneta_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac_addr,
+ uint32_t index, uint32_t vmdq __rte_unused)
+{
+ struct mvneta_priv *priv = dev->data->dev_private;
+ char buf[ETHER_ADDR_FMT_SIZE];
+ int ret;
+
+ if (index == 0)
+ /* For setting index 0, mrvl_mac_addr_set() should be used.*/
+ return -1;
+
+ if (!priv->ppio)
+ return 0;
+
+ ret = neta_ppio_add_mac_addr(priv->ppio, mac_addr->addr_bytes);
+ if (ret) {
+ ether_format_addr(buf, sizeof(buf), mac_addr);
+ MVNETA_LOG(ERR, "Failed to add mac %s", buf);
+ return -1;
+ }
+
+ return 0;
+}
+
+/**
* DPDK callback to set the primary MAC address.
*
* @param dev
@@ -634,6 +701,8 @@ static const struct eth_dev_ops mvneta_ops = {
.link_update = mvneta_link_update,
.promiscuous_enable = mvneta_promiscuous_enable,
.promiscuous_disable = mvneta_promiscuous_disable,
+ .mac_addr_remove = mvneta_mac_addr_remove,
+ .mac_addr_add = mvneta_mac_addr_add,
.mac_addr_set = mvneta_mac_addr_set,
.mtu_set = mvneta_mtu_set,
.dev_infos_get = mvneta_dev_infos_get,
--
2.7.4