From: Luca Boccassi <bluca@debian.org>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Cc: declan.doherty@intel.com, matan@mellanox.com, ehkinzie@gmail.com,
Chas Williams <chas3@att.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: ensure fairness among slaves
Date: Wed, 19 Sep 2018 17:06:59 +0100 [thread overview]
Message-ID: <1537373219.10481.26.camel@debian.org> (raw)
In-Reply-To: <20180919154825.5183-1-3chas3@gmail.com>
On Wed, 2018-09-19 at 11:48 -0400, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
>
> Some PMDs, especially ones with vector receives, require a minimum
> number
> of receive buffers in order to receive any packets. If the first
> slave
> read leaves less than this number available, a read from the next
> slave
> may return 0 implying that the slave doesn't have any packets which
> results in skipping over that slave as the next active slave.
>
> To fix this, implement round robin for the slaves during receive that
> is only advanced to the next slave at the end of each receive burst.
> This should also provide some additional fairness in processing in
> bond_ethdev_rx_burst as well.
>
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chas Williams <chas3@att.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 50 ++++++++++++++++++++++
> ------------
> 1 file changed, 32 insertions(+), 18 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-09-19 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 15:48 [dpdk-dev] " Chas Williams
2018-09-19 16:06 ` Luca Boccassi [this message]
2018-09-20 6:28 ` Matan Azrad
2018-09-20 12:47 ` Chas Williams
2018-09-20 12:52 ` [dpdk-dev] [PATCH v2] net/bonding: fix RX slave fairness Chas Williams
2018-09-21 18:27 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537373219.10481.26.camel@debian.org \
--to=bluca@debian.org \
--cc=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ehkinzie@gmail.com \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).