DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: <dev@dpdk.org>, Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>,
	<stable@dpdk.org>
Subject: [dpdk-dev] [PATCH v2 2/4] net/failsafe: add checks for deferred queue setup
Date: Thu, 20 Sep 2018 14:55:50 +0100	[thread overview]
Message-ID: <1537451752-28759-3-git-send-email-arybchenko@solarflare.com> (raw)
In-Reply-To: <1537451752-28759-1-git-send-email-arybchenko@solarflare.com>

From: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>

Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
Cc: stable@dpdk.org

Signed-off-by: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
 drivers/net/failsafe/failsafe_ops.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index d989a17bf..9608d09cb 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -338,6 +338,11 @@ fs_rx_queue_setup(struct rte_eth_dev *dev,
 	uint8_t i;
 	int ret;
 
+	if (rx_conf->rx_deferred_start) {
+		ERROR("Rx queue deferred start is not supported");
+		return -EINVAL;
+	}
+
 	fs_lock(dev, 0);
 	rxq = dev->data->rx_queues[rx_queue_id];
 	if (rxq != NULL) {
@@ -495,6 +500,11 @@ fs_tx_queue_setup(struct rte_eth_dev *dev,
 	uint8_t i;
 	int ret;
 
+	if (tx_conf->tx_deferred_start) {
+		ERROR("Tx queue deferred start is not supported");
+		return -EINVAL;
+	}
+
 	fs_lock(dev, 0);
 	txq = dev->data->tx_queues[tx_queue_id];
 	if (txq != NULL) {
-- 
2.17.1

  parent reply	other threads:[~2018-09-20 13:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  7:16 [dpdk-dev] [PATCH 0/4] net/failsafe: support deferred queue start Andrew Rybchenko
2018-08-29  7:16 ` [dpdk-dev] [PATCH 1/4] app/testpmd: add queue deferred start switch Andrew Rybchenko
2018-09-03 16:56   ` Ferruh Yigit
2018-09-20 13:24     ` Andrew Rybchenko
2018-08-29  7:16 ` [dpdk-dev] [PATCH 2/4] net/failsafe: add checks for deferred queue setup Andrew Rybchenko
2018-08-29  7:16 ` [dpdk-dev] [PATCH 3/4] net/failsafe: add Rx queue start and stop functions Andrew Rybchenko
2018-08-29  7:16 ` [dpdk-dev] [PATCH 4/4] net/failsafe: add Tx " Andrew Rybchenko
2018-08-29  9:35 ` [dpdk-dev] [PATCH 0/4] net/failsafe: support deferred queue start Gaëtan Rivet
2018-09-20 13:55 ` [dpdk-dev] [PATCH v2 " Andrew Rybchenko
2018-09-20 13:55   ` [dpdk-dev] [PATCH v2 1/4] app/testpmd: add queue deferred start switch Andrew Rybchenko
2018-09-20 13:55   ` Andrew Rybchenko [this message]
2018-09-20 13:55   ` [dpdk-dev] [PATCH v2 3/4] net/failsafe: add Rx queue start and stop functions Andrew Rybchenko
2018-09-20 13:55   ` [dpdk-dev] [PATCH v2 4/4] net/failsafe: add Tx " Andrew Rybchenko
2018-09-21  0:21   ` [dpdk-dev] [PATCH v2 0/4] net/failsafe: support deferred queue start Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1537451752-28759-3-git-send-email-arybchenko@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=Ian.Dolzhansky@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).