From: Nikolay Nikolaev <nicknickolaev@gmail.com>
To: maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v4 0/5] vhost: vhost_user.c code cleanup
Date: Sun, 23 Sep 2018 00:16:23 +0300 [thread overview]
Message-ID: <153765091094.29126.1031571146095035538.stgit@T460> (raw)
vhost: vhost_user.c code cleanup
This patchesries introduce a set of code redesigns in vhost_user.c.
The goal is to unify and simplify vhost-user message handling. The
patches do not intend to introduce any functional changes.
v4 changes:
- use struct VhostUserMsg as the coding style guide suggests (Anatoly Burakov)
- VH_RESULT_FATAL is removed as not needed anymore (Maxime Coquelin)
v3 changes:
- rebased on top of git://dpdk.org/next/dpdk-next-virtio dead0602
- introduce VH_RESULT_FATAL (Maxime Coquelin)
- vhost_user_set_features return VH_RESULT_FATAL on failure.
This allows keeping the propagate error logic (Ilya Maximets)
- fixed vhost_user_set_vring_kick and vhost_user_set_protocol_features
return VH_RESULT_ERR upon failure
- fixed missing break in case VH_RESULT_ERR (Ilya Maximets)
- fixed a type on the description of 2/5 patch (Maxime Coquelin)
v2 changes:
- Fix the comments by Tiwei Bie
- Keep the old behavior
- Fall through when the callback returns VH_RESULT_ERR
- Fall through if the request is out of range
---
Nikolay Nikolaev (5):
vhost: unify struct VhostUserMsg usage
vhost: make message handling functions prepare the reply
vhost: handle unsupported message types in functions
vhost: unify message handling function signature
vhost: message handling implemented as a callback array
lib/librte_vhost/vhost_user.c | 393 ++++++++++++++++++++++-------------------
1 file changed, 208 insertions(+), 185 deletions(-)
--
Signature
next reply other threads:[~2018-09-22 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 21:16 Nikolay Nikolaev [this message]
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 1/5] vhost: unify struct VhostUserMsg usage Nikolay Nikolaev
2018-09-24 9:55 ` Burakov, Anatoly
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 2/5] vhost: make message handling functions prepare the reply Nikolay Nikolaev
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 3/5] vhost: handle unsupported message types in functions Nikolay Nikolaev
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 4/5] vhost: unify message handling function signature Nikolay Nikolaev
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 5/5] vhost: message handling implemented as a callback array Nikolay Nikolaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153765091094.29126.1031571146095035538.stgit@T460 \
--to=nicknickolaev@gmail.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).