DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v4 0/5] vhost: vhost_user.c code cleanup
@ 2018-09-22 21:16 Nikolay Nikolaev
  2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 1/5] vhost: unify struct VhostUserMsg usage Nikolay Nikolaev
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Nikolay Nikolaev @ 2018-09-22 21:16 UTC (permalink / raw)
  To: maxime.coquelin, tiwei.bie, zhihong.wang; +Cc: dev

vhost: vhost_user.c code cleanup

This patchesries introduce a set of code redesigns in vhost_user.c.

The goal is to unify and simplify vhost-user message handling. The
patches do not intend to introduce any functional changes.

v4 changes:
 - use struct VhostUserMsg as the coding style guide suggests (Anatoly Burakov)
 - VH_RESULT_FATAL is removed as not needed anymore (Maxime Coquelin)

v3 changes:
 - rebased on top of git://dpdk.org/next/dpdk-next-virtio dead0602
 - introduce VH_RESULT_FATAL (Maxime Coquelin)
 - vhost_user_set_features return VH_RESULT_FATAL on failure.
   This allows keeping the propagate error logic (Ilya Maximets)
 - fixed vhost_user_set_vring_kick and vhost_user_set_protocol_features
   return VH_RESULT_ERR upon failure
 - fixed missing break in case VH_RESULT_ERR (Ilya Maximets)
 - fixed a type on the description of 2/5 patch (Maxime Coquelin)

v2 changes:
 - Fix the comments by Tiwei Bie
 - Keep the old behavior
   - Fall through when the callback returns VH_RESULT_ERR
   - Fall through if the request is out of range

---

Nikolay Nikolaev (5):
      vhost: unify struct VhostUserMsg usage
      vhost: make message handling functions prepare the reply
      vhost: handle unsupported message types in functions
      vhost: unify message handling function signature
      vhost: message handling implemented as a callback array


 lib/librte_vhost/vhost_user.c |  393 ++++++++++++++++++++++-------------------
 1 file changed, 208 insertions(+), 185 deletions(-)

--
Signature

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-09-24  9:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-22 21:16 [dpdk-dev] [PATCH v4 0/5] vhost: vhost_user.c code cleanup Nikolay Nikolaev
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 1/5] vhost: unify struct VhostUserMsg usage Nikolay Nikolaev
2018-09-24  9:55   ` Burakov, Anatoly
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 2/5] vhost: make message handling functions prepare the reply Nikolay Nikolaev
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 3/5] vhost: handle unsupported message types in functions Nikolay Nikolaev
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 4/5] vhost: unify message handling function signature Nikolay Nikolaev
2018-09-22 21:16 ` [dpdk-dev] [PATCH v4 5/5] vhost: message handling implemented as a callback array Nikolay Nikolaev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).