From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 9474E56A3 for ; Mon, 24 Sep 2018 17:21:13 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id z14-v6so2603639wrs.10 for ; Mon, 24 Sep 2018 08:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=3bG9pzHMlN7mMlaFZSWqMGfL+ntqGIFU+oKeQ0nGPHY=; b=f+X//CTRyYDo3dLj0ITFHkaDTzObW7hVpZx9jU9AaWlkBO7AoJj4TountwBoctUGl4 E639CjtvuDx+7/HW7yagsZn/ZT+N72eiM4IsMJFhO9qs23qNXf88Yfw9I8fwSzv29cAb 7yL+cymANpeBRb9+VGMHd0XTW2bZ2PGOIOZjjnZ+U8qFMMlxWoz4KeARJE3nKHQluUdk agy9SGPX2EtR6DJqlq/Z+Onri4fNLm5hUTWObAd+tF6uUCWhpLHulJVPiWPEKzU19mhI JkLNeAgXkq/FllYl76wa3YxDWafaykhYlZqknMC/Mf3/n3jIq8MndQ4UXqZ/bkRmvWqA bueg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=3bG9pzHMlN7mMlaFZSWqMGfL+ntqGIFU+oKeQ0nGPHY=; b=tCqbFo7Sd/ljXJ+oUhUzyCYTwGUp9Cc3fajMsIerhJ5TBRbAmGIYCNlQDqNb7RNrcP KYjhQzPULqIDMDJrUs+LDe3Pxs2k1RMQpNK+U6EvHYcigFamapZKDskuXYErkpRFssul b4irCtTg6X+MYoozF4COIApRy8A+HN0dge+2G6sYF4bKnI/nPezeadWLljb4tzXbn+jh UzxS4KF2utD8jF5txlTKsGZh+aZ5plOEPBO5GW+xGY7lfza60kr7pS6zK/MyfFhrFJWq W0VxebPNmGvtSdGVqXA3aT6gbGiw8Ufoyg3D+O5QY6SDGe4REbkUa9GDMV1mWM5OlpL3 Ee9A== X-Gm-Message-State: ABuFfohCymTm28PISQs6lTVGVL668xwbEq5eZGtVsfTeTA+te7C57nFU SAPjkmQNSYHiyLthG561Ie2LrYCRPXCUtQ== X-Google-Smtp-Source: ACcGV62hmE3SSOYh369/xNTnsP7JYbP3M7wosXm0n57eLtdnl17uvZpVuDj1L6sbpGTe8q4XS26doA== X-Received: by 2002:adf:e109:: with SMTP id d9-v6mr9348220wri.42.1537802472923; Mon, 24 Sep 2018 08:21:12 -0700 (PDT) Received: from [127.0.1.1] ([82.146.27.14]) by smtp.gmail.com with ESMTPSA id g2-v6sm4103580wmh.16.2018.09.24.08.21.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Sep 2018 08:21:12 -0700 (PDT) From: Nikolay Nikolaev To: maxime.coquelin@redhat.com, anatoly.burakov@intel.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org Date: Mon, 24 Sep 2018 18:21:10 +0300 Message-ID: <153780242838.17494.4512397995243433980.stgit@T460> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] [PATCH v5 0/5] vhost_user.c code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 15:21:13 -0000 vhost: vhost_user.c code cleanup This patchesries introduce a set of code redesigns in vhost_user.c. The goal is to unify and simplify vhost-user message handling. The patches do not intend to introduce any functional changes. v5 changes: - fixed the usage of struct VhostUserMsg in all patches (Anatoly Burakov) v4 changes: - use struct VhostUserMsg as the coding style guide suggests (Anatoly Burakov) - VH_RESULT_FATAL is removed as not needed anymore (Maxime Coquelin) v3 changes: - rebased on top of git://dpdk.org/next/dpdk-next-virtio dead0602 - introduce VH_RESULT_FATAL (Maxime Coquelin) - vhost_user_set_features return VH_RESULT_FATAL on failure. This allows keeping the propagate error logic (Ilya Maximets) - fixed vhost_user_set_vring_kick and vhost_user_set_protocol_features return VH_RESULT_ERR upon failure - fixed missing break in case VH_RESULT_ERR (Ilya Maximets) - fixed a type on the description of 2/5 patch (Maxime Coquelin) v2 changes: - Fix the comments by Tiwei Bie - Keep the old behavior - Fall through when the callback returns VH_RESULT_ERR - Fall through if the request is out of range --- Nikolay Nikolaev (5): vhost: unify struct VhostUserMsg usage vhost: make message handling functions prepare the reply vhost: handle unsupported message types in functions vhost: unify message handling function signature vhost: message handling implemented as a callback array lib/librte_vhost/vhost_user.c | 393 ++++++++++++++++++++++------------------- 1 file changed, 208 insertions(+), 185 deletions(-) -- Signature