From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id E13B81B119
 for <dev@dpdk.org>; Tue, 25 Sep 2018 14:22:49 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id j15-v6so19055948wrt.8
 for <dev@dpdk.org>; Tue, 25 Sep 2018 05:22:49 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:content-transfer-encoding:mime-version;
 bh=WBkmfabuAPTNKsT8JH+4R+HKpzodvsqIHHGSrOWujfg=;
 b=qUSGz8SJ+OwvCKXmLD15HMwcQICo/Elwj3m5jfjaA95VE02MsxMwyu6Rcc2Q5zU/go
 lbYGLKKXkDDm8swmBzN1p3FCyVJqkEYI4bjNxP2WoQJJah8T1s8qq1t+i4PgP6/Ul8r6
 XdgEKbCcvQtD0W8FnDLWk7fqioIW1klRGKgxGDNh8T8fuEF0yPb/hVN00LSdXlffgrlB
 Rstn5kCR4jYB3fdJ0OgBi2vUoA6m4egtwqaEOoDJAT18jFF4rlxnyLKkcGIdn3jJnpl4
 Hq0611gA0kcYwRjFZazU69IaFjc4crOR0HXsHud1E4I29nU4+ZASIdag4VlhF931o60b
 RqRw==
X-Gm-Message-State: ABuFfoigObZ6Lzuhg/0AVSZ7q08Lsj4TUauri0gRVuToAUYGnGk0tBvi
 GUMqgir9TDIim2hpszafHGY=
X-Google-Smtp-Source: ACcGV600tRY35rXW6eoQsyCLd6VoXVQzBwxe9AoThr5e2LhRyGLLeZdpsipjJxE7ya0tanN9S2fetg==
X-Received: by 2002:adf:e30e:: with SMTP id
 b14-v6mr746298wrj.158.1537878169365; 
 Tue, 25 Sep 2018 05:22:49 -0700 (PDT)
Received: from localhost ([2001:1be0:110d:fcfe:489f:80a9:5d59:c6bd])
 by smtp.gmail.com with ESMTPSA id e127-v6sm1100427wmg.45.2018.09.25.05.22.47
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 25 Sep 2018 05:22:48 -0700 (PDT)
Message-ID: <1537878167.10481.46.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Thomas Monjalon <thomas@monjalon.net>, Konstantin Ananyev
 <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Date: Tue, 25 Sep 2018 13:22:47 +0100
In-Reply-To: <1912621.YvyjYky8PI@xps>
References: <1535129226-25510-1-git-send-email-konstantin.ananyev@intel.com>
 <1912621.YvyjYky8PI@xps>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero
 priority
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 12:22:50 -0000

On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote:
> 24/08/2018 18:47, Konstantin Ananyev:
> > If user specifies priority=3D0 for some of ACL rules
> > that can cause rte_acl_classify to return wrong results.
> > The reason is that priority zero is used internally for no-match
> > nodes.
> > See more details at: https://bugs.dpdk.org/show_bug.cgi?id=3D79.
> > The simplest way to overcome the issue is just not allow zero
> > to be a valid priority for the rule.
> >=20
> > Fixes: dc276b5780c2 ("acl: new library")
> >=20
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>=20
> Cc: stable@dpdk.org
>=20
> Applied with below title, thanks
> 	acl: forbid rule with priority zero

Hi,

This patch is marked for stable, but it changes an enum in a public
header so it looks like an ABI breakage? Have I got it wrong?

--=20
Kind regards,
Luca Boccassi