From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 51C5D1B14C; Wed, 26 Sep 2018 12:22:18 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id z3-v6so14575283wrr.13; Wed, 26 Sep 2018 03:22:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=5pJgcw6KI0ZXthMVyttDM1bh/Y1dtjSAvwFReRJoKmc=; b=jxxJkkR4ST+dSHe95ux11H5j7L7tW70T3AK3t/hUFCJnU02aGly9VSLwU0hFXlJTOK 8/6kwfYvFrpHT+nmYoREeZzqaHA2+7b3Bx7NXBbunatxAO2O4vHCTDnFGXTWtiYQBNMB b4+zq9hzq4/UrP15yMdBHdPMrhPJ8KDEQ89BDYp6BHllzkivT32+hsve/Hubi6yktGHz co0wAZinoxjRrdYuKj+VBQhOL6uZ2t9w48zN1oU+HXPcULBv1QcC77HpWnV4O7vO7uOR Wl4qa7nckqVhr1KU5GvDKoo3qB/e4uniOqo7qsSQdvUbnY902fBWAWHCLy42JHzgiB4s /kKA== X-Gm-Message-State: ABuFfojhvTuK3QpCa/rzuWST8yH31z3Px7B4kgJRGuj3H2JD37ndE2Cb 1aCio4vPGg0a1RslkL1+8pqE2fT5 X-Google-Smtp-Source: ACcGV62CFasFPbvji6if0cc3WilYp560MYLIJ6ob2igUya8BH1G5FYKpLA1R0eiFl1t4zXG8gnTPlA== X-Received: by 2002:a5d:5111:: with SMTP id s17-v6mr4539341wrt.162.1537957337660; Wed, 26 Sep 2018 03:22:17 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:489f:80a9:5d59:c6bd]) by smtp.gmail.com with ESMTPSA id l40-v6sm4663786wre.38.2018.09.26.03.22.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Sep 2018 03:22:16 -0700 (PDT) Message-ID: <1537957336.8363.3.camel@debian.org> From: Luca Boccassi To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org, ferruh.yigit@intel.com Date: Wed, 26 Sep 2018 11:22:16 +0100 In-Reply-To: <20180815170932.23536-1-bluca@debian.org> References: <20180815170932.23536-1-bluca@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 10:22:18 -0000 On Wed, 2018-08-15 at 18:09 +0100, Luca Boccassi wrote: > ixgbe_identify_phy_x550em() was missing the code to handle > unidentified > PHY that has been there in 82599 so it was not able to complete > initialization of ixgbe sequence if no sfp plugged in. > Port it over to return an appropriate type and complete init sequence > properly. >=20 > Fixes: d2e72774e58c ("ixgbe/base: support X550") > Cc: stable@dpdk.org >=20 > Signed-off-by: Luca Boccassi > --- > =C2=A0drivers/net/ixgbe/base/ixgbe_x550.c | 19 ++++++++++++++++--- > =C2=A01 file changed, 16 insertions(+), 3 deletions(-) Ping. Any chance this series could get a review? Thanks! --=20 Kind regards, Luca Boccassi