From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A55CA288C
 for <dev@dpdk.org>; Thu, 26 Jul 2018 10:05:48 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id F0CBA21FE5;
 Thu, 26 Jul 2018 04:05:47 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 26 Jul 2018 04:05:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=+pwATbitLTMEaktrdJsFkSfZvl
 Ri79UI6SslFOcxsDo=; b=qFt/K1lV+lm050B7FCXBkQpD2VgHARAyG6iCbQahXY
 mC8TSbMnnDv/iekOlThHuLOgBNJ41J5yg5HWbTTXa/ie8wivs2LQZPdWdtT4mVAf
 drDas076+eglQzaQNXVyA96CUcqdOPw1MQuC0oleH5gacojVTirQ+xCGpv6xOU+1
 k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=+pwATb
 itLTMEaktrdJsFkSfZvlRi79UI6SslFOcxsDo=; b=UR9elDa9BO6CGdNB4hBKmZ
 z3vxFDVrX3MKAAHtxCMQx1vIoYd5vdJIP/nl0TT/HK/GTaTK29nPQiA+HpL3md/r
 9W2/bDBEIU3aBjnITu0wVB2fX1v0EIYDZw3vqAkvWSL/SLVxCC9NgFZSmvypJfzY
 STCb7Nrr9JQOZCu5dcDTUj+1gOf4FNynIND5eWsJUV0VCCbujHyaIfXDZaWD1WP4
 M5vzK/TuGJKjWTewcuIBlf/5uRCBoJC4kvHLcLpLcXlsZygAhSkeZCT0MmsNJcMU
 /pXrMeIwsf/gUyl38yDboIi1q5Gh4UZAYol5CktDCFZUIxKBIRoQW/yGPt99CmgQ
 ==
X-ME-Proxy: <xmx:24BZW46j0bMoQTtGAWTUBUWcAzUf-vj2z8Ul2yo2_n0oZKclI1RwkA>
 <xmx:24BZW-wqbdZmb7lpVbw-RAdNAKfY2hKbI6FibG0GGk1gGJ2cFOpXtA>
 <xmx:24BZW1Bfx_I-oxC-Miv1G-rL4LyvvUAehOaNo1qH5kPPf0NyVrnFVA>
 <xmx:24BZW_NE6Mj8gbjWaqozvJlr_KIsJtFt9vNTzvzVScTxGNb8b8yypQ>
 <xmx:24BZW7QGJB-Wwo36pXfYUx_VQzjJG3Jtow5VmUrM4OYRIsF8UlaZ4w>
 <xmx:24BZW-THfoIbOwiKzhXZRGRDP2WLfLP1NypUd_MdCFhwk1k4FNFPaw>
X-ME-Sender: <xms:24BZW5tm6aPH_879ttAhvIUAnGn3u-fzbgRzue6Po-esEQxK6g0dRQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 28DE91025C;
 Thu, 26 Jul 2018 04:05:47 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Date: Thu, 26 Jul 2018 10:05:42 +0200
Message-ID: <1538032.sZLDVcAvc4@xps>
In-Reply-To: <20180720132825.772-1-bruce.richardson@intel.com>
References: <20180720132825.772-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] build: improve error message for missing
	dependency
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2018 08:05:48 -0000

20/07/2018 15:28, Bruce Richardson:
> When building a driver or library and a required internal dependency
> is missing, the error message printed was:
> 
>     Tried to get unknown variable "shared_rte_<libname>".
> 
> However, a better way to handle this is to catch the missing variable
> earlier and convert it into a proper message, informing the user
> that the required dependency is missing, and most importantly, what
> library or driver wanted that dependency.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks