* [dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command redundant code in function i40e_nvmupd_validate_command, when "cmd->data_size < 1" it'll return I40E_NVMUPD_INVALID, and in function "i40e_nvmupd_command" when "upd_cmd == I40E_NVMUPD_STATUS", it check "!cmd->data_size" again, but it's no need.
@ 2018-09-27 7:21 Li Han
0 siblings, 0 replies; only message in thread
From: Li Han @ 2018-09-27 7:21 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, Li Han
Signed-off-by: Li Han <han.li1@zte.com.cn>
---
drivers/net/i40e/base/i40e_nvm.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c
index c77dac0..5de22e4 100644
--- a/drivers/net/i40e/base/i40e_nvm.c
+++ b/drivers/net/i40e/base/i40e_nvm.c
@@ -869,11 +869,6 @@ enum i40e_status_code i40e_nvmupd_command(struct i40e_hw *hw,
* going into the state machine
*/
if (upd_cmd == I40E_NVMUPD_STATUS) {
- if (!cmd->data_size) {
- *perrno = -EFAULT;
- return I40E_ERR_BUF_TOO_SHORT;
- }
-
bytes[0] = hw->nvmupd_state;
if (cmd->data_size >= 4) {
--
1.8.3.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-09-27 7:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 7:21 [dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command redundant code in function i40e_nvmupd_validate_command, when "cmd->data_size < 1" it'll return I40E_NVMUPD_INVALID, and in function "i40e_nvmupd_command" when "upd_cmd == I40E_NVMUPD_STATUS", it check "!cmd->data_size" again, but it's no need Li Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).