[dpdk-dev] [PATCH 0/2] remove unnecessary call of rte intr enable

[dpdk-dev] [PATCH 0/2] remove unnecessary call of rte intr enable

[Xiaoyun Li]

Since rte_intr_enable is called at init and start time. Remove it in
interrupt_action function to avoid too many system calls.

Xiaoyun Li (2):
  net/ixgbe: remove unnecessary call of rte intr enable
  net/i40e: remove unnecessary call of rte intr enable

 drivers/net/i40e/i40e_ethdev.c   | 1 -
 drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++------
 2 files changed, 3 insertions(+), 7 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH 1/2] net/ixgbe: remove unnecessary call of rte intr enable

[Xiaoyun Li]

Since rte_intr_enable is called at init and start time. Remove it in
interrupt_action function to avoid too many system calls.

Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 26b1927..9ffd8cb 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -217,8 +217,7 @@ static int ixgbe_dev_lsc_interrupt_setup(struct rte_eth_dev *dev, uint8_t on);
 static int ixgbe_dev_macsec_interrupt_setup(struct rte_eth_dev *dev);
 static int ixgbe_dev_rxq_interrupt_setup(struct rte_eth_dev *dev);
 static int ixgbe_dev_interrupt_get_status(struct rte_eth_dev *dev);
-static int ixgbe_dev_interrupt_action(struct rte_eth_dev *dev,
-				      struct rte_intr_handle *handle);
+static int ixgbe_dev_interrupt_action(struct rte_eth_dev *dev);
 static void ixgbe_dev_interrupt_handler(void *param);
 static void ixgbe_dev_interrupt_delayed_handler(void *param);
 static int ixgbe_add_rar(struct rte_eth_dev *dev, struct ether_addr *mac_addr,
@@ -4282,8 +4281,7 @@ ixgbe_dev_link_status_print(struct rte_eth_dev *dev)
  *  - On failure, a negative value.
  */
 static int
-ixgbe_dev_interrupt_action(struct rte_eth_dev *dev,
-			   struct rte_intr_handle *intr_handle)
+ixgbe_dev_interrupt_action(struct rte_eth_dev *dev)
 {
 	struct ixgbe_interrupt *intr =
 		IXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);
@@ -4334,7 +4332,6 @@ ixgbe_dev_interrupt_action(struct rte_eth_dev *dev,
 
 	PMD_DRV_LOG(DEBUG, "enable intr immediately");
 	ixgbe_enable_intr(dev);
-	rte_intr_enable(intr_handle);
 
 	return 0;
 }
@@ -4417,7 +4414,7 @@ ixgbe_dev_interrupt_handler(void *param)
 	struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
 
 	ixgbe_dev_interrupt_get_status(dev);
-	ixgbe_dev_interrupt_action(dev, dev->intr_handle);
+	ixgbe_dev_interrupt_action(dev);
 }
 
 static int
-- 
2.7.4

[dpdk-dev] [PATCH 2/2] net/i40e: remove unnecessary call of rte intr enable

[Xiaoyun Li]

Since rte_intr_enable is called at init and start time. Remove it in
interrupt_action function to avoid too many system calls.

Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 85a6a86..426d54c 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -6549,7 +6549,6 @@ i40e_dev_interrupt_handler(void *param)
 done:
 	/* Enable interrupt */
 	i40e_pf_enable_irq0(hw);
-	rte_intr_enable(dev->intr_handle);
 }
 
 int
-- 
2.7.4

Re: [dpdk-dev] [PATCH 0/2] remove unnecessary call of rte intr enable

[Zhang, Qi Z]

> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Thursday, September 27, 2018 5:22 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH 0/2] remove unnecessary call of rte intr enable
> 
> Since rte_intr_enable is called at init and start time. Remove it in
> interrupt_action function to avoid too many system calls.
> 
> Xiaoyun Li (2):
>   net/ixgbe: remove unnecessary call of rte intr enable
>   net/i40e: remove unnecessary call of rte intr enable
> 
>  drivers/net/i40e/i40e_ethdev.c   | 1 -
>  drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++------
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 
> --
> 2.7.4

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi