From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id CF1F81B0F8 for ; Mon, 1 Oct 2018 13:24:09 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id z4-v6so12109729wrb.1 for ; Mon, 01 Oct 2018 04:24:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=aCL19NRsAdk0/dNbCTmqxYr/0SSKwL0gCOdWjIyETZs=; b=l4kwxe2SlCXnOPmcJ5st1c6YWf9xxcc8AiLd+IZyHDqOiZfkfc/ryjkUzrVhZaWNHr DFDGVicedGNNnaur3oer6JMgJnhpEkeqrVfbNNXGihZ5yVPoz19EQLg/G9iFqz5xzQ5B GIYNkn16A23R8wTL1Wm/9h/xbI0+sxGq9erGkWcNTgFtERgqnBnfPX5utP7fO31u8a/i 2f/CagLQKqIlMeIBypzFjN0dTBMyLjGusoSTrGOenigDEqR1sa2ZrzoYdLMk9BNC+sD7 Hn07nxBqkxWUnOEWg95CcHEO4J6ZVtvIToevUJMy81eKz1Fmh1S3mp+vHt/Wa6av20VH EJ0Q== X-Gm-Message-State: ABuFfoj4d/saSxuXXucz0FVE9EQnNHPGb++8QUKfKHyWoUJzL8Auu555 3rkUCYdV+vI0f2BUdshHQ3U= X-Google-Smtp-Source: ACcGV60otiuROoCea5gDRNA/HrkDXzmseFlhah0KArRW4twU77CD6fKZ1P253rIZJYedYyD/ZIiW1Q== X-Received: by 2002:adf:8022:: with SMTP id 31-v6mr4256714wrk.16.1538393049316; Mon, 01 Oct 2018 04:24:09 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id p9-v6sm8195033wmc.37.2018.10.01.04.24.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Oct 2018 04:24:07 -0700 (PDT) Message-ID: <1538393046.8363.42.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , Timothy Redaelli Cc: dev@dpdk.org, mvarlese@suse.de, christian.ehrhardt@canonical.com Date: Mon, 01 Oct 2018 12:24:06 +0100 In-Reply-To: <20181001110600.GA2520@bricha3-MOBL.ger.corp.intel.com> References: <20180928175803.12955-1-bluca@debian.org> <20181001091714.GA25944@bricha3-MOBL.ger.corp.intel.com> <20181001092530.GB25944@bricha3-MOBL.ger.corp.intel.com> <1538387162.8363.41.camel@debian.org> <20181001124209.7ea2f69b@redhat.com> <20181001110600.GA2520@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 11:24:10 -0000 On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote: > On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote: > > On Mon, 01 Oct 2018 10:46:02 +0100 > > Luca Boccassi wrote: > >=20 > > > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > > > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson > > > > wrote:=C2=A0=C2=A0 > > > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi > > > > > wrote:=C2=A0=C2=A0 > > > > > > Allow users and packagers to override the default > > > > > > dpdk/drivers > > > > > > subdirectory where the PMDs get installed under $lib. > > > > > >=20 > > > > > > Signed-off-by: Luca Boccassi > > > > > > ---=C2=A0=C2=A0 > > > > >=20 > > > > > I'm ok with this change, but what is the current location > > > > > used by > > > > > distro's > > > > > right now? I mistakenly never checked what was done before I > > > > > used > > > > > dpdk/drivers as a default value, and I'd like the default to > > > > > match > > > > > the > > > > > common option if possible. > > > > >=20 > > > > > /Bruce > > > > > =C2=A0=C2=A0 > > > >=20 > > > > Replying to my own question, I've just checked on CentOS and > > > > Debian, > > > > and it > > > > appears both are using directory "dpdk-pmds" as the subdir > > > > name. > > > > Therefore, > > > > let's just make that the default. [Does it need to be > > > > configurable in > > > > that > > > > case?] > > > >=20 > > > > /Bruce=C2=A0=C2=A0 > > >=20 > > > If the default is the one I expect then I'm fine without having > > > an > > > option (actually happier - less things to configure). > > >=20 > > > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last > > > January :-) > > > We changed because using a single directory creates problems when > > > multiple different ABI versions are installed, due to the EAL > > > autoload > > > from that directory. So we need a different subdirectory per ABI > > > revision. > > >=20 > > > We were actually talking with Timothy a while ago to make this > > > consistent across our distros, and perhaps Marco can chip in as > > > well. > > >=20 > > > Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm > > > not > > > too fussy on $something, it can be drivers or pmds or something > > > else. > > >=20 > >=20 > > LGTM. > > If needed, we can just do a compatibility symlink using the current > > dpdk-pmds path > >=20 >=20 > One suggestion/comment. Would using a unique directory per release > not lead > to clobbering up the lib directory unnecessarily? How about having a > single > "dpdk" or "dpdk-pmds" directory in lib, and having $MAJORVER as a > subdir > under that? >=20 > E.g. dpdk/pmds-18.08/, dpdk/pmds-18.11/, or dpdk-pmds/18.08/ > dpdk-pmds/18.11 >=20 > [The former of the above would be my preference, since I don't like > having > hypenated names, and like having "dpdk" alone as a folder name :-)] >=20 > /Bruce dpdk/pmds-XX.YY/ would work for me. Timothy and Marco? --=20 Kind regards, Luca Boccassi